Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: chrome/browser/resources/options2/chromeos/internet_detail.js

Issue 10174010: Add BSSID, frequency and signal strength to WiFi details. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge with trunk. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options2/chromeos/internet_detail.js
diff --git a/chrome/browser/resources/options2/chromeos/internet_detail.js b/chrome/browser/resources/options2/chromeos/internet_detail.js
index f6b17ba9f4e2c944085670cc9fa873fd20f723a1..d9f9f55420147c47ffa69c76d760aff9b5efae3c 100644
--- a/chrome/browser/resources/options2/chromeos/internet_detail.js
+++ b/chrome/browser/resources/options2/chromeos/internet_detail.js
@@ -674,6 +674,12 @@ cr.define('options.internet', function() {
detailsPage.shared = data.shared;
$('wifi-connection-state').textContent = data.connectionState;
$('wifi-ssid').textContent = data.ssid;
+ if (data.bssid && data.bssid.length > 0) {
+ $('wifi-bssid').textContent = data.bssid;
+ $('wifi-bssid-entry').hidden = false;
+ } else {
+ $('wifi-bssid-entry').hidden = true;
+ }
$('wifi-ip-address').textContent = inetAddress;
$('wifi-subnet-address').textContent = inetSubnetAddress;
$('wifi-gateway').textContent = inetGateway;
@@ -684,6 +690,14 @@ cr.define('options.internet', function() {
} else {
$('wifi-security-entry').hidden = true;
}
+ // Frequency is in MHz.
+ var frequency = localStrings.getString('inetFrequencyFormat');
+ frequency = frequency.replace('$1', data.frequency);
+ $('wifi-frequency').textContent = frequency;
+ // Signal strength as percentage.
+ var signalStrength = localStrings.getString('inetSignalStrengthFormat');
+ signalStrength = signalStrength.replace('$1', data.strength);
+ $('wifi-signal-strength').textContent = signalStrength;
if (data.hardwareAddress) {
$('wifi-hardware-address').textContent = data.hardwareAddress;
$('wifi-hardware-address-entry').hidden = false;

Powered by Google App Engine
This is Rietveld 408576698