Add BSSID, frequency and signal strength to WiFi details.

Add BSSID, frequency and signal strength to WiFi details.

BUG=chromium-os:19569
TEST=Open the settings tab and connect to a WiFi network. Ensure that signal strength and frequency are show in the connection details. BSSID should also be visible for 802.11 networks.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133818

[kevers, 2012-04-24 12:49:05]

Hi Chris,

Can you please have a look at this CL.  Adds BSSID, frequency, and signal
strength to the Wifi details dialog.

[csilv, 2012-04-24 21:34:38]

lgtm

http://codereview.chromium.org/10174010/diff/2001/chrome/app/generated_resour...
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/10174010/diff/2001/chrome/app/generated_resour...
chrome/app/generated_resources.grd:13123: +        <ph
name="GHZ">$1<ex>2.4</ex></ph>MHz
Not a big deal, but perhaps the name parameter should be "MHZ" and the example
should be 2400.  Also, should there be a space?  "2400MHz" looks odd to me, but
perhaps that's fine.

[kevers, 2012-04-24 22:06:15]

http://codereview.chromium.org/10174010/diff/2001/chrome/app/generated_resour...
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/10174010/diff/2001/chrome/app/generated_resour...
chrome/app/generated_resources.grd:13123: +        <ph
name="GHZ">$1<ex>2.4</ex></ph>MHz
On 2012/04/24 21:34:39, csilv wrote:
> Not a big deal, but perhaps the name parameter should be "MHZ" and the example
> should be 2400.  Also, should there be a space?  "2400MHz" looks odd to me,
but
> perhaps that's fine.

Whoops.  Switched from GHz to MHz without updating the example.  Good catch. 
Indeed, the layout does look better with a space.  Done.

[commit-bot: I haz the power, 2012-04-24 22:09:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kevers@chromium.org/10174010/7001

[commit-bot: I haz the power, 2012-04-25 00:07:49]

Change committed as 133818