Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 10174008: Fix up ordering in ProfileIOData. (Closed)

Created:
8 years, 8 months ago by willchan no longer on Chromium
Modified:
8 years, 8 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Fix up ordering in ProfileIOData. It's important to destroy the ResourceContext before we start destroying the URLRequestContext and the members it owns, because destroying the ResourceContext will cancel the pending URLRequests for that ResourceContext in the ResourceDispatcherHost. Those URLRequests may reference the URLRequestContexts in their destructors, so we need to make sure ResourceContext is destroyed first. While doing this, I did some other cleanup: * discovered that we could eliminate HostContentSettingsMap from ProfileIOData, w00t! * reordered URLRequestContext after the members it points to, so it gets destroyed before they get destroyed * moved the virtuals in ProfileIOData::ResourceContext to be public, since the parent class changed them to be public BUG=90971 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133793

Patch Set 1 #

Patch Set 2 : Merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -27 lines) Patch
M chrome/browser/profiles/off_the_record_profile_io_data.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_impl_io_data.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_impl_io_data.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.h View 6 chunks +27 lines, -14 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 6 chunks +9 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
willchan no longer on Chromium
8 years, 8 months ago (2012-04-23 17:36:47 UTC) #1
willchan no longer on Chromium
+eroman
8 years, 8 months ago (2012-04-24 21:02:55 UTC) #2
Elliot Glaysher
lgtm
8 years, 8 months ago (2012-04-24 21:06:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/willchan@chromium.org/10174008/5001
8 years, 8 months ago (2012-04-24 21:09:43 UTC) #4
commit-bot: I haz the power
8 years, 8 months ago (2012-04-24 22:55:21 UTC) #5
Change committed as 133793

Powered by Google App Engine
This is Rietveld 408576698