Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5123)

Unified Diff: chrome/common/extensions/url_pattern_unittest.cc

Issue 10174001: Add an API for hosted apps to check their install and running states. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/url_pattern_unittest.cc
diff --git a/chrome/common/extensions/url_pattern_unittest.cc b/chrome/common/extensions/url_pattern_unittest.cc
index 10dff3d66b4b6744257753e798a78272e58cdfa7..2006c546a238e0a757e6963c8014d4af66fd5d2a 100644
--- a/chrome/common/extensions/url_pattern_unittest.cc
+++ b/chrome/common/extensions/url_pattern_unittest.cc
@@ -666,3 +666,17 @@ TEST(ExtensionURLPatternTest, CanReusePatternWithParse) {
EXPECT_FALSE(pattern3.MatchesURL(GURL("http://aa.com/path")));
EXPECT_TRUE(pattern3.MatchesURL(GURL("http://aa.com:88/path")));
}
+
+TEST(ExtensionURLPatternTest, IgnoresTrailingSlash) {
+ URLPattern pattern1(URLPattern::SCHEME_ALL);
+ EXPECT_EQ(URLPattern::PARSE_SUCCESS, pattern1.Parse("http://a.com/b/"));
+ EXPECT_TRUE(pattern1.MatchesURL(GURL("http://a.com/b")));
+
+ URLPattern pattern2(URLPattern::SCHEME_ALL);
+ EXPECT_EQ(URLPattern::PARSE_SUCCESS, pattern2.Parse("http://a.com/"));
+ EXPECT_TRUE(pattern2.MatchesURL(GURL("http://a.com")));
+
+ URLPattern pattern3(URLPattern::SCHEME_ALL);
+ EXPECT_EQ(URLPattern::PARSE_SUCCESS, pattern3.Parse("http://a.com/b"));
+ EXPECT_TRUE(pattern3.MatchesURL(GURL("http://a.com/b/")));
+}

Powered by Google App Engine
This is Rietveld 408576698