Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 10173009: Always create URLRequestContextGetter in ChromotingHostContext. (Closed)

Created:
8 years, 8 months ago by Sergey Ulanov
Modified:
8 years, 1 month ago
Reviewers:
Jamie
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Always create URLRequestContextGetter in ChromotingHostContext. BUG=124728 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133974

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -15 lines) Patch
M remoting/host/chromoting_host_context.cc View 1 chunk +3 lines, -7 lines 0 comments Download
M remoting/host/url_fetcher_unittest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M remoting/host/url_request_context.h View 1 chunk +3 lines, -2 lines 0 comments Download
M remoting/host/url_request_context.cc View 1 2 3 4 2 chunks +62 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Sergey Ulanov
8 years, 8 months ago (2012-04-24 20:33:35 UTC) #1
Jamie
lgtm
8 years, 8 months ago (2012-04-25 15:59:11 UTC) #2
Sergey Ulanov
Currently ProxyConfigServiceLinux doesn't work on plugin threads and fix is blocked is blocked by some ...
8 years, 8 months ago (2012-04-25 18:04:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/10173009/12001
8 years, 8 months ago (2012-04-25 18:04:51 UTC) #4
commit-bot: I haz the power
Try job failure for 10173009-12001 (retry) on linux_rel for step "compile" (clobber build). It's a ...
8 years, 8 months ago (2012-04-25 18:38:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/10173009/14003
8 years, 8 months ago (2012-04-25 18:48:46 UTC) #6
commit-bot: I haz the power
Try job failure for 10173009-14003 (retry) on mac_rel for step "compile" (clobber build). It's a ...
8 years, 8 months ago (2012-04-25 19:12:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/10173009/12
8 years, 8 months ago (2012-04-25 19:18:15 UTC) #8
commit-bot: I haz the power
Change committed as 133974
8 years, 8 months ago (2012-04-25 20:48:52 UTC) #9
pauljensen
Are these issues resolved? It looks like it. I'm wondering if base::OneShotTimer is safe to ...
8 years, 1 month ago (2012-11-06 18:48:12 UTC) #10
Sergey Ulanov
8 years, 1 month ago (2012-11-06 21:06:09 UTC) #11
On 2012/11/06 18:48:12, pauljensen wrote:
> Are these issues resolved?  It looks like it.  I'm wondering if
> base::OneShotTimer is safe to use now.

I fixed base::OneShotTimer to use base::ThreadTaskRunnerHandle, but currently
the host plugin doesn't set base::ThreadTaskRunnerHandle for the main plugin
thread. In other words OneShotTimer still doesn't work on the main thread in the
remoting plugin, but it should be easy to fix.


> 
> On 2012/04/25 18:04:31, sergeyu wrote:
> > Currently ProxyConfigServiceLinux doesn't work on plugin threads and fix is
> > blocked is blocked by some changes in src/base
> > (http://codereview.chromium.org/10210008/ and
> > http://codereview.chromium.org/10213012/). I commented the Linux version of
> > ProxyConfigService creation. For now the Linux version will just use
> > ProxyConfigServiceDirect(). I'll fix that later once it is possible to use
> > ProxyConfigServiceLinux on plugin threads.
> > 
> > On 2012/04/25 15:59:11, Jamie wrote:
> > > lgtm

Powered by Google App Engine
This is Rietveld 408576698