Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Unified Diff: base/android/java/org/chromium/base/CalledByNativeUnchecked.java

Issue 10171009: Update net/android/network_library.cc with fresher code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: added comments, fixed caller Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/android/java/org/chromium/base/CalledByNativeUnchecked.java
diff --git a/base/android/java/org/chromium/base/CalledByNativeUnchecked.java b/base/android/java/org/chromium/base/CalledByNativeUnchecked.java
new file mode 100644
index 0000000000000000000000000000000000000000..8b6fdf4c0bf3535a1353580f8a9ce7f4b506eeab
--- /dev/null
+++ b/base/android/java/org/chromium/base/CalledByNativeUnchecked.java
@@ -0,0 +1,22 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+package org.chromium.base;
+
+import java.lang.annotation.ElementType;
+import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
+import java.lang.annotation.Target;
+
+// It only makes sense to use this annotation on methods that declare a throws... spec.
+// However, note that the exception received native side maybe an 'unchecked' (RuntimeExpception)
+// such as NullPointerException, so the native code should differentiate these cases.
+// Usage of this should be very rare; where possible handle exceptions in the Java side and use a
+// return value to indicate success / failure.
+
+@Target(ElementType.METHOD)
+@Retention(RetentionPolicy.RUNTIME)
+public @interface CalledByNativeUnchecked {
+ public String value() default "";
+}
« no previous file with comments | « no previous file | build/android/gtest_filter/net_unittests_disabled » ('j') | build/android/gtest_filter/net_unittests_disabled » ('J')

Powered by Google App Engine
This is Rietveld 408576698