chrome/browser/ui/views/html_dialog_view_browsertest.cc - Issue 10171006: Convert more users away from DOMView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/html_dialog_view_browsertest.cc

Issue 10171006: Convert more users away from DOMView. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/html_dialog_view_browsertest.cc

===================================================================

--- chrome/browser/ui/views/html_dialog_view_browsertest.cc (revision 133597)

+++ chrome/browser/ui/views/html_dialog_view_browsertest.cc (working copy)

@@ -114,7 +114,6 @@

ASSERT_TRUE(web_contents != NULL);

views::Widget::CreateWindowWithParent(

html_view, web_contents->GetView()->GetTopLevelNativeWindow());

- html_view->InitDialog();

html_view->GetWidget()->Show();

// TestHtmlDialogView should quit current message loop on size change.

@@ -134,8 +133,8 @@

actual_bounds = html_view->GetWidget()->GetClientAreaScreenBounds();

EXPECT_EQ(set_bounds, actual_bounds);

- rwhv_bounds = html_view->dom_contents()->web_contents()->

- GetRenderWidgetHostView()->GetViewBounds();

+ rwhv_bounds =

+ html_view->web_contents()->GetRenderWidgetHostView()->GetViewBounds();

EXPECT_LT(0, rwhv_bounds.width());

EXPECT_LT(0, rwhv_bounds.height());

EXPECT_GE(set_bounds.width(), rwhv_bounds.width());

@@ -150,8 +149,8 @@

actual_bounds = html_view->GetWidget()->GetClientAreaScreenBounds();

EXPECT_EQ(set_bounds, actual_bounds);

- rwhv_bounds = html_view->dom_contents()->web_contents()->

- GetRenderWidgetHostView()->GetViewBounds();

+ rwhv_bounds =

+ html_view->web_contents()->GetRenderWidgetHostView()->GetViewBounds();

EXPECT_LT(0, rwhv_bounds.width());

EXPECT_LT(0, rwhv_bounds.height());

EXPECT_GE(set_bounds.width(), rwhv_bounds.width());

@@ -166,8 +165,8 @@

actual_bounds = html_view->GetWidget()->GetClientAreaScreenBounds();

EXPECT_EQ(set_bounds, actual_bounds);

- rwhv_bounds = html_view->dom_contents()->web_contents()->

- GetRenderWidgetHostView()->GetViewBounds();

+ rwhv_bounds =

+ html_view->web_contents()->GetRenderWidgetHostView()->GetViewBounds();

EXPECT_LT(0, rwhv_bounds.width());

EXPECT_LT(0, rwhv_bounds.height());

EXPECT_GE(set_bounds.width(), rwhv_bounds.width());

« no previous file with comments | « chrome/browser/ui/views/html_dialog_view.cc ('k') | chrome/browser/ui/views/keyboard_overlay_delegate.cc » ('j') | no next file with comments »