NaCl: Update revision in DEPS, r8414 -> r8430

NaCl: Update toolchain revision in DEPS, r8169 -> r8428

BUG=none
TEST=nacl_integration

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134483

[vissi, 2012-04-28 14:45:34]

On 2012/04/28 14:33:41, vissi wrote:

Updated to make less impact by not bumping NaCl toolchain revision only.

[Mark Seaborn, 2012-04-28 17:35:24]

On 2012/04/28 14:45:34, vissi wrote:
> Updated to make less impact by not bumping NaCl toolchain revision only.

You mean "by bumping the NaCl toolchain revision only".  No "not". :-)

I think this is the way to go.  The toolchain revision is largely independent of
the NaCl revision now.  I haven't been updating nacl_toolchain_revision with my
regular nacl_revision updates, because I didn't want to have to worry about the
impact on Chromium's "gclient sync" times.  I would be quite happy if someone
else took on the task of updating nacl_toolchain_revision at suitable times.

So, LGTM.  I'll tick the commit box.

Mark

[commit-bot: I haz the power, 2012-04-28 17:35:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vissi@google.com/10170050/6001

[vissi, 2012-04-28 17:59:27]

Thanks. Btw, I submitted a tiny patch to your bump script at github, and
@pasko suggested to move it to main nacl repo.

суббота, 28 апреля 2012 г. пользователь писал:

> On 2012/04/28 14:45:34, vissi wrote:
>
>> Updated to make less impact by not bumping NaCl toolchain revision only.
>>
>
> You mean "by bumping the NaCl toolchain revision only".  No "not". :-)
>
> I think this is the way to go.  The toolchain revision is largely
> independent of
> the NaCl revision now.  I haven't been updating nacl_toolchain_revision
> with my
> regular nacl_revision updates, because I didn't want to have to worry
> about the
> impact on Chromium's "gclient sync" times.  I would be quite happy if
> someone
> else took on the task of updating nacl_toolchain_revision at suitable
> times.
>
> So, LGTM.  I'll tick the commit box.
>
> Mark
>
>
>
https://chromiumcodereview.**appspot.com/10170050/<https://chromiumcodereview...
>


-- 
V.S.

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To post to this group, send email to native-client-reviews@googlegroups.com.
To unsubscribe from this group, send email to
native-client-reviews+unsubscribe@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/native-client-reviews?hl=en.

[vissi, 2012-04-28 17:59:29]

Thanks. Btw, I submitted a tiny patch to your bump script at github, and
@pasko suggested to move it to main nacl repo.

суббота, 28 апреля 2012 г. пользователь писал:

> On 2012/04/28 14:45:34, vissi wrote:
>
>> Updated to make less impact by not bumping NaCl toolchain revision only.
>>
>
> You mean "by bumping the NaCl toolchain revision only".  No "not". :-)
>
> I think this is the way to go.  The toolchain revision is largely
> independent of
> the NaCl revision now.  I haven't been updating nacl_toolchain_revision
> with my
> regular nacl_revision updates, because I didn't want to have to worry
> about the
> impact on Chromium's "gclient sync" times.  I would be quite happy if
> someone
> else took on the task of updating nacl_toolchain_revision at suitable
> times.
>
> So, LGTM.  I'll tick the commit box.
>
> Mark
>
>
>
https://chromiumcodereview.**appspot.com/10170050/<https://chromiumcodereview...
>


-- 
V.S.

[commit-bot: I haz the power, 2012-04-28 20:18:20]

Try job failure for 10170050-6001 (retry) on win_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-04-28 21:59:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vissi@google.com/10170050/6001

[commit-bot: I haz the power, 2012-04-29 00:01:16]

Change committed as 134483

[Nico, 2012-04-29 01:06:15]

Hi,

this turned check_licenses on the linux clobber builder red. The error message
looks like the check has caught something real
(http://build.chromium.org/p/chromium/builders/Linux/builds/23545/steps/check_...):


'native_client/toolchain/linux_x86/share/gdb/python/gdb/prompt.py' has
non-whitelisted license 'GPL (v3 or later)'
'native_client/toolchain/linux_x86/share/gdb/python/gdb/__init__.py' has
non-whitelisted license 'GPL (v3 or later)'
'native_client/toolchain/linux_x86/share/gdb/python/gdb/types.py' has
non-whitelisted license 'GPL (v3 or later)'
'native_client/toolchain/linux_x86/share/gdb/python/gdb/printing.py' has
non-whitelisted license 'GPL (v3 or later)'
'native_client/toolchain/linux_x86/share/gdb/python/gdb/command/prompt.py' has
non-whitelisted license 'GPL (v3 or later)'
'native_client/toolchain/linux_x86/share/gdb/python/gdb/command/__init__.py' has
non-whitelisted license 'GPL (v3 or later)'
'native_client/toolchain/linux_x86/share/gdb/python/gdb/command/pretty_printers.py'
has non-whitelisted license 'GPL (v3 or later)'
'native_client/toolchain/linux_x86_newlib/share/gdb/python/gdb/prompt.py' has
non-whitelisted license 'GPL (v3 or later)'
'native_client/toolchain/linux_x86_newlib/share/gdb/python/gdb/__init__.py' has
non-whitelisted license 'GPL (v3 or later)'
'native_client/toolchain/linux_x86_newlib/share/gdb/python/gdb/types.py' has
non-whitelisted license 'GPL (v3 or later)'
'native_client/toolchain/linux_x86_newlib/share/gdb/python/gdb/printing.py' has
non-whitelisted license 'GPL (v3 or later)'
'native_client/toolchain/linux_x86_newlib/share/gdb/python/gdb/command/prompt.py'
has non-whitelisted license 'GPL (v3 or later)'
'native_client/toolchain/linux_x86_newlib/share/gdb/python/gdb/command/__init__.py'
has non-whitelisted license 'GPL (v3 or later)'
'native_client/toolchain/linux_x86_newlib/share/gdb/python/gdb/command/pretty_printers.py'
has non-whitelisted license 'GPL (v3 or later)'

FAILED

Please read http://www.chromium.org/developers/adding-3rd-party-libraries
for more info how to handle the failure.

[Mark Seaborn, 2012-04-29 01:24:45]

Evgeny and Andrey added GDB to the NaCl toolchain recently, I think.

Mark

On 28 April 2012 18:06, <thakis@chromium.org> wrote:

> Hi,
>
> this turned check_licenses on the linux clobber builder red. The error
> message
> looks like the check has caught something real
> (http://build.chromium.org/p/**chromium/builders/Linux/**
>
builds/23545/steps/check_**licenses/logs/stdio<http://build.chromium.org/p/chromium/builders/Linux/builds/23545/steps/check_licenses/logs/stdio>
> ):
>
>
> 'native_client/toolchain/**linux_x86/share/gdb/python/**gdb/prompt.py' has
> non-whitelisted license 'GPL (v3 or later)'
> 'native_client/toolchain/**linux_x86/share/gdb/python/**gdb/__init__.py'
> has
> non-whitelisted license 'GPL (v3 or later)'
> 'native_client/toolchain/**linux_x86/share/gdb/python/**gdb/types.py' has
> non-whitelisted license 'GPL (v3 or later)'
> 'native_client/toolchain/**linux_x86/share/gdb/python/**gdb/printing.py'
> has
> non-whitelisted license 'GPL (v3 or later)'
>
'native_client/toolchain/**linux_x86/share/gdb/python/**gdb/command/prompt.py'
> has
> non-whitelisted license 'GPL (v3 or later)'
>
'native_client/toolchain/**linux_x86/share/gdb/python/**gdb/command/__init__.py'
> has
> non-whitelisted license 'GPL (v3 or later)'
> 'native_client/toolchain/**linux_x86/share/gdb/python/**
> gdb/command/pretty_printers.**py'
> has non-whitelisted license 'GPL (v3 or later)'
> 'native_client/toolchain/**linux_x86_newlib/share/gdb/**python/gdb/prompt.py'
> has
> non-whitelisted license 'GPL (v3 or later)'
>
'native_client/toolchain/**linux_x86_newlib/share/gdb/**python/gdb/__init__.py'
> has
> non-whitelisted license 'GPL (v3 or later)'
> 'native_client/toolchain/**linux_x86_newlib/share/gdb/**python/gdb/types.py'
> has
> non-whitelisted license 'GPL (v3 or later)'
>
'native_client/toolchain/**linux_x86_newlib/share/gdb/**python/gdb/printing.py'
> has
> non-whitelisted license 'GPL (v3 or later)'
> 'native_client/toolchain/**linux_x86_newlib/share/gdb/**
> python/gdb/command/prompt.py'
> has non-whitelisted license 'GPL (v3 or later)'
> 'native_client/toolchain/**linux_x86_newlib/share/gdb/**
> python/gdb/command/__init__.**py'
> has non-whitelisted license 'GPL (v3 or later)'
> 'native_client/toolchain/**linux_x86_newlib/share/gdb/**
> python/gdb/command/pretty_**printers.py'
> has non-whitelisted license 'GPL (v3 or later)'
>
> FAILED
>
> Please read http://www.chromium.org/**developers/adding-3rd-party-**
> libraries <http://www.chromium.org/developers/adding-3rd-party-libraries>
> for more info how to handle the failure.
>
>
>
>
>
>
http://codereview.chromium.**org/10170050/<http://codereview.chromium.org/101...
>
> --
> You received this message because you are subscribed to the Google Groups
> "Native-Client-Reviews" group.
> To post to this group, send email to native-client-reviews@**
> googlegroups.com <native-client-reviews@googlegroups.com>.
> To unsubscribe from this group, send email to native-client-reviews+**
>
unsubscribe@googlegroups.com<native-client-reviews%2Bunsubscribe@googlegroups...
> .
> For more options, visit this group at http://groups.google.com/**
>
group/native-client-reviews?**hl=en<http://groups.google.com/group/native-client-reviews?hl=en>
> .
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To post to this group, send email to native-client-reviews@googlegroups.com.
To unsubscribe from this group, send email to
native-client-reviews+unsubscribe@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/native-client-reviews?hl=en.

[Mark Seaborn, 2012-04-29 01:24:46]

Evgeny and Andrey added GDB to the NaCl toolchain recently, I think.

Mark

On 28 April 2012 18:06, <thakis@chromium.org> wrote:

> Hi,
>
> this turned check_licenses on the linux clobber builder red. The error
> message
> looks like the check has caught something real
> (http://build.chromium.org/p/**chromium/builders/Linux/**
>
builds/23545/steps/check_**licenses/logs/stdio<http://build.chromium.org/p/chromium/builders/Linux/builds/23545/steps/check_licenses/logs/stdio>
> ):
>
>
> 'native_client/toolchain/**linux_x86/share/gdb/python/**gdb/prompt.py' has
> non-whitelisted license 'GPL (v3 or later)'
> 'native_client/toolchain/**linux_x86/share/gdb/python/**gdb/__init__.py'
> has
> non-whitelisted license 'GPL (v3 or later)'
> 'native_client/toolchain/**linux_x86/share/gdb/python/**gdb/types.py' has
> non-whitelisted license 'GPL (v3 or later)'
> 'native_client/toolchain/**linux_x86/share/gdb/python/**gdb/printing.py'
> has
> non-whitelisted license 'GPL (v3 or later)'
>
'native_client/toolchain/**linux_x86/share/gdb/python/**gdb/command/prompt.py'
> has
> non-whitelisted license 'GPL (v3 or later)'
>
'native_client/toolchain/**linux_x86/share/gdb/python/**gdb/command/__init__.py'
> has
> non-whitelisted license 'GPL (v3 or later)'
> 'native_client/toolchain/**linux_x86/share/gdb/python/**
> gdb/command/pretty_printers.**py'
> has non-whitelisted license 'GPL (v3 or later)'
> 'native_client/toolchain/**linux_x86_newlib/share/gdb/**python/gdb/prompt.py'
> has
> non-whitelisted license 'GPL (v3 or later)'
>
'native_client/toolchain/**linux_x86_newlib/share/gdb/**python/gdb/__init__.py'
> has
> non-whitelisted license 'GPL (v3 or later)'
> 'native_client/toolchain/**linux_x86_newlib/share/gdb/**python/gdb/types.py'
> has
> non-whitelisted license 'GPL (v3 or later)'
>
'native_client/toolchain/**linux_x86_newlib/share/gdb/**python/gdb/printing.py'
> has
> non-whitelisted license 'GPL (v3 or later)'
> 'native_client/toolchain/**linux_x86_newlib/share/gdb/**
> python/gdb/command/prompt.py'
> has non-whitelisted license 'GPL (v3 or later)'
> 'native_client/toolchain/**linux_x86_newlib/share/gdb/**
> python/gdb/command/__init__.**py'
> has non-whitelisted license 'GPL (v3 or later)'
> 'native_client/toolchain/**linux_x86_newlib/share/gdb/**
> python/gdb/command/pretty_**printers.py'
> has non-whitelisted license 'GPL (v3 or later)'
>
> FAILED
>
> Please read http://www.chromium.org/**developers/adding-3rd-party-**
> libraries <http://www.chromium.org/developers/adding-3rd-party-libraries>
> for more info how to handle the failure.
>
>
>
>
>
>
http://codereview.chromium.**org/10170050/<http://codereview.chromium.org/101...
>
> --
> You received this message because you are subscribed to the Google Groups
> "Native-Client-Reviews" group.
> To post to this group, send email to native-client-reviews@**
> googlegroups.com <native-client-reviews@googlegroups.com>.
> To unsubscribe from this group, send email to native-client-reviews+**
>
unsubscribe@googlegroups.com<native-client-reviews%2Bunsubscribe@googlegroups...
> .
> For more options, visit this group at http://groups.google.com/**
>
group/native-client-reviews?**hl=en<http://groups.google.com/group/native-client-reviews?hl=en>
> .
>
>

[khim, 2012-04-29 09:46:50]

On Sun, Apr 29, 2012 at 5:24 AM, Mark Seaborn <mseaborn@chromium.org> wrote:

> Evgeny and Andrey added GDB to the NaCl toolchain recently, I think.
>
> s/added/upgraded/

GDB was already there, but it was GDB 6.8 (and used GPLv2+), now it's GDB
7.4 (and uses GPLv3+).


> Mark
>
> On 28 April 2012 18:06, <thakis@chromium.org> wrote:
>
>> Hi,
>>
>> this turned check_licenses on the linux clobber builder red. The error
>> message
>> looks like the check has caught something real
>> (http://build.chromium.org/p/**chromium/builders/Linux/**
>>
builds/23545/steps/check_**licenses/logs/stdio<http://build.chromium.org/p/chromium/builders/Linux/builds/23545/steps/check_licenses/logs/stdio>
>> ):
>>
>>
>> 'native_client/toolchain/**linux_x86/share/gdb/python/**gdb/prompt.py'
>> has
>> non-whitelisted license 'GPL (v3 or later)'
>> 'native_client/toolchain/**linux_x86/share/gdb/python/**gdb/__init__.py'
>> has
>> non-whitelisted license 'GPL (v3 or later)'
>> 'native_client/toolchain/**linux_x86/share/gdb/python/**gdb/types.py' has
>> non-whitelisted license 'GPL (v3 or later)'
>> 'native_client/toolchain/**linux_x86/share/gdb/python/**gdb/printing.py'
>> has
>> non-whitelisted license 'GPL (v3 or later)'
>>
'native_client/toolchain/**linux_x86/share/gdb/python/**gdb/command/prompt.py'
>> has
>> non-whitelisted license 'GPL (v3 or later)'
>>
'native_client/toolchain/**linux_x86/share/gdb/python/**gdb/command/__init__.py'
>> has
>> non-whitelisted license 'GPL (v3 or later)'
>> 'native_client/toolchain/**linux_x86/share/gdb/python/**
>> gdb/command/pretty_printers.**py'
>> has non-whitelisted license 'GPL (v3 or later)'
>>
'native_client/toolchain/**linux_x86_newlib/share/gdb/**python/gdb/prompt.py'
>> has
>> non-whitelisted license 'GPL (v3 or later)'
>>
'native_client/toolchain/**linux_x86_newlib/share/gdb/**python/gdb/__init__.py'
>> has
>> non-whitelisted license 'GPL (v3 or later)'
>> 'native_client/toolchain/**linux_x86_newlib/share/gdb/**python/gdb/types.py'
>> has
>> non-whitelisted license 'GPL (v3 or later)'
>>
'native_client/toolchain/**linux_x86_newlib/share/gdb/**python/gdb/printing.py'
>> has
>> non-whitelisted license 'GPL (v3 or later)'
>> 'native_client/toolchain/**linux_x86_newlib/share/gdb/**
>> python/gdb/command/prompt.py'
>> has non-whitelisted license 'GPL (v3 or later)'
>> 'native_client/toolchain/**linux_x86_newlib/share/gdb/**
>> python/gdb/command/__init__.**py'
>> has non-whitelisted license 'GPL (v3 or later)'
>> 'native_client/toolchain/**linux_x86_newlib/share/gdb/**
>> python/gdb/command/pretty_**printers.py'
>> has non-whitelisted license 'GPL (v3 or later)'
>>
>> FAILED
>>
>> Please read http://www.chromium.org/**developers/adding-3rd-party-**
>> libraries <http://www.chromium.org/developers/adding-3rd-party-libraries>
>> for more info how to handle the failure.
>>
>>
>>
>>
>>
>>
http://codereview.chromium.**org/10170050/<http://codereview.chromium.org/101...
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "Native-Client-Reviews" group.
>> To post to this group, send email to native-client-reviews@**
>> googlegroups.com <native-client-reviews@googlegroups.com>.
>> To unsubscribe from this group, send email to native-client-reviews+**
>>
unsubscribe@googlegroups.com<native-client-reviews%2Bunsubscribe@googlegroups...
>> .
>> For more options, visit this group at http://groups.google.com/**
>>
group/native-client-reviews?**hl=en<http://groups.google.com/group/native-client-reviews?hl=en>
>> .
>>
>>
>

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To post to this group, send email to native-client-reviews@googlegroups.com.
To unsubscribe from this group, send email to
native-client-reviews+unsubscribe@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/native-client-reviews?hl=en.

[khim, 2012-04-29 09:46:51]

On Sun, Apr 29, 2012 at 5:24 AM, Mark Seaborn <mseaborn@chromium.org> wrote:

> Evgeny and Andrey added GDB to the NaCl toolchain recently, I think.
>
> s/added/upgraded/

GDB was already there, but it was GDB 6.8 (and used GPLv2+), now it's GDB
7.4 (and uses GPLv3+).


> Mark
>
> On 28 April 2012 18:06, <thakis@chromium.org> wrote:
>
>> Hi,
>>
>> this turned check_licenses on the linux clobber builder red. The error
>> message
>> looks like the check has caught something real
>> (http://build.chromium.org/p/**chromium/builders/Linux/**
>>
builds/23545/steps/check_**licenses/logs/stdio<http://build.chromium.org/p/chromium/builders/Linux/builds/23545/steps/check_licenses/logs/stdio>
>> ):
>>
>>
>> 'native_client/toolchain/**linux_x86/share/gdb/python/**gdb/prompt.py'
>> has
>> non-whitelisted license 'GPL (v3 or later)'
>> 'native_client/toolchain/**linux_x86/share/gdb/python/**gdb/__init__.py'
>> has
>> non-whitelisted license 'GPL (v3 or later)'
>> 'native_client/toolchain/**linux_x86/share/gdb/python/**gdb/types.py' has
>> non-whitelisted license 'GPL (v3 or later)'
>> 'native_client/toolchain/**linux_x86/share/gdb/python/**gdb/printing.py'
>> has
>> non-whitelisted license 'GPL (v3 or later)'
>>
'native_client/toolchain/**linux_x86/share/gdb/python/**gdb/command/prompt.py'
>> has
>> non-whitelisted license 'GPL (v3 or later)'
>>
'native_client/toolchain/**linux_x86/share/gdb/python/**gdb/command/__init__.py'
>> has
>> non-whitelisted license 'GPL (v3 or later)'
>> 'native_client/toolchain/**linux_x86/share/gdb/python/**
>> gdb/command/pretty_printers.**py'
>> has non-whitelisted license 'GPL (v3 or later)'
>>
'native_client/toolchain/**linux_x86_newlib/share/gdb/**python/gdb/prompt.py'
>> has
>> non-whitelisted license 'GPL (v3 or later)'
>>
'native_client/toolchain/**linux_x86_newlib/share/gdb/**python/gdb/__init__.py'
>> has
>> non-whitelisted license 'GPL (v3 or later)'
>> 'native_client/toolchain/**linux_x86_newlib/share/gdb/**python/gdb/types.py'
>> has
>> non-whitelisted license 'GPL (v3 or later)'
>>
'native_client/toolchain/**linux_x86_newlib/share/gdb/**python/gdb/printing.py'
>> has
>> non-whitelisted license 'GPL (v3 or later)'
>> 'native_client/toolchain/**linux_x86_newlib/share/gdb/**
>> python/gdb/command/prompt.py'
>> has non-whitelisted license 'GPL (v3 or later)'
>> 'native_client/toolchain/**linux_x86_newlib/share/gdb/**
>> python/gdb/command/__init__.**py'
>> has non-whitelisted license 'GPL (v3 or later)'
>> 'native_client/toolchain/**linux_x86_newlib/share/gdb/**
>> python/gdb/command/pretty_**printers.py'
>> has non-whitelisted license 'GPL (v3 or later)'
>>
>> FAILED
>>
>> Please read http://www.chromium.org/**developers/adding-3rd-party-**
>> libraries <http://www.chromium.org/developers/adding-3rd-party-libraries>
>> for more info how to handle the failure.
>>
>>
>>
>>
>>
>>
http://codereview.chromium.**org/10170050/<http://codereview.chromium.org/101...
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "Native-Client-Reviews" group.
>> To post to this group, send email to native-client-reviews@**
>> googlegroups.com <native-client-reviews@googlegroups.com>.
>> To unsubscribe from this group, send email to native-client-reviews+**
>>
unsubscribe@googlegroups.com<native-client-reviews%2Bunsubscribe@googlegroups...
>> .
>> For more options, visit this group at http://groups.google.com/**
>>
group/native-client-reviews?**hl=en<http://groups.google.com/group/native-client-reviews?hl=en>
>> .
>>
>>
>

[Nico, 2012-04-29 14:48:30]

Please check if it's OK to use gpl3 software at Google (see the page linked
above) and undo the gdb update if not.
On Apr 29, 2012 2:46 AM, "Victor Khimenko" <khim@chromium.org> wrote:

>
>
> On Sun, Apr 29, 2012 at 5:24 AM, Mark Seaborn <mseaborn@chromium.org>wrote:
>
>> Evgeny and Andrey added GDB to the NaCl toolchain recently, I think.
>>
>> s/added/upgraded/
>
> GDB was already there, but it was GDB 6.8 (and used GPLv2+), now it's GDB
> 7.4 (and uses GPLv3+).
>
>
>> Mark
>>
>> On 28 April 2012 18:06, <thakis@chromium.org> wrote:
>>
>>> Hi,
>>>
>>> this turned check_licenses on the linux clobber builder red. The error
>>> message
>>> looks like the check has caught something real
>>> (http://build.chromium.org/p/**chromium/builders/Linux/**
>>>
builds/23545/steps/check_**licenses/logs/stdio<http://build.chromium.org/p/chromium/builders/Linux/builds/23545/steps/check_licenses/logs/stdio>
>>> ):
>>>
>>>
>>> 'native_client/toolchain/**linux_x86/share/gdb/python/**gdb/prompt.py'
>>> has
>>> non-whitelisted license 'GPL (v3 or later)'
>>> 'native_client/toolchain/**linux_x86/share/gdb/python/**gdb/__init__.py'
>>> has
>>> non-whitelisted license 'GPL (v3 or later)'
>>> 'native_client/toolchain/**linux_x86/share/gdb/python/**gdb/types.py'
>>> has
>>> non-whitelisted license 'GPL (v3 or later)'
>>> 'native_client/toolchain/**linux_x86/share/gdb/python/**gdb/printing.py'
>>> has
>>> non-whitelisted license 'GPL (v3 or later)'
>>>
'native_client/toolchain/**linux_x86/share/gdb/python/**gdb/command/prompt.py'
>>> has
>>> non-whitelisted license 'GPL (v3 or later)'
>>>
'native_client/toolchain/**linux_x86/share/gdb/python/**gdb/command/__init__.py'
>>> has
>>> non-whitelisted license 'GPL (v3 or later)'
>>> 'native_client/toolchain/**linux_x86/share/gdb/python/**
>>> gdb/command/pretty_printers.**py'
>>> has non-whitelisted license 'GPL (v3 or later)'
>>>
'native_client/toolchain/**linux_x86_newlib/share/gdb/**python/gdb/prompt.py'
>>> has
>>> non-whitelisted license 'GPL (v3 or later)'
>>>
'native_client/toolchain/**linux_x86_newlib/share/gdb/**python/gdb/__init__.py'
>>> has
>>> non-whitelisted license 'GPL (v3 or later)'
>>>
'native_client/toolchain/**linux_x86_newlib/share/gdb/**python/gdb/types.py'
>>> has
>>> non-whitelisted license 'GPL (v3 or later)'
>>>
'native_client/toolchain/**linux_x86_newlib/share/gdb/**python/gdb/printing.py'
>>> has
>>> non-whitelisted license 'GPL (v3 or later)'
>>> 'native_client/toolchain/**linux_x86_newlib/share/gdb/**
>>> python/gdb/command/prompt.py'
>>> has non-whitelisted license 'GPL (v3 or later)'
>>> 'native_client/toolchain/**linux_x86_newlib/share/gdb/**
>>> python/gdb/command/__init__.**py'
>>> has non-whitelisted license 'GPL (v3 or later)'
>>> 'native_client/toolchain/**linux_x86_newlib/share/gdb/**
>>> python/gdb/command/pretty_**printers.py'
>>> has non-whitelisted license 'GPL (v3 or later)'
>>>
>>> FAILED
>>>
>>> Please read http://www.chromium.org/**developers/adding-3rd-party-**
>>> libraries<http://www.chromium.org/developers/adding-3rd-party-libraries>
>>> for more info how to handle the failure.
>>>
>>>
>>>
>>>
>>>
>>>
http://codereview.chromium.**org/10170050/<http://codereview.chromium.org/101...
>>>
>>> --
>>> You received this message because you are subscribed to the Google
>>> Groups "Native-Client-Reviews" group.
>>> To post to this group, send email to native-client-reviews@**
>>> googlegroups.com <native-client-reviews@googlegroups.com>.
>>> To unsubscribe from this group, send email to native-client-reviews+**
>>>
unsubscribe@googlegroups.com<native-client-reviews%2Bunsubscribe@googlegroups...
>>> .
>>> For more options, visit this group at http://groups.google.com/**
>>>
group/native-client-reviews?**hl=en<http://groups.google.com/group/native-client-reviews?hl=en>
>>> .
>>>
>>>
>>
>

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To post to this group, send email to native-client-reviews@googlegroups.com.
To unsubscribe from this group, send email to
native-client-reviews+unsubscribe@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/native-client-reviews?hl=en.

[Nico, 2012-04-29 14:48:30]

Please check if it's OK to use gpl3 software at Google (see the page linked
above) and undo the gdb update if not.
On Apr 29, 2012 2:46 AM, "Victor Khimenko" <khim@chromium.org> wrote:

>
>
> On Sun, Apr 29, 2012 at 5:24 AM, Mark Seaborn <mseaborn@chromium.org>wrote:
>
>> Evgeny and Andrey added GDB to the NaCl toolchain recently, I think.
>>
>> s/added/upgraded/
>
> GDB was already there, but it was GDB 6.8 (and used GPLv2+), now it's GDB
> 7.4 (and uses GPLv3+).
>
>
>> Mark
>>
>> On 28 April 2012 18:06, <thakis@chromium.org> wrote:
>>
>>> Hi,
>>>
>>> this turned check_licenses on the linux clobber builder red. The error
>>> message
>>> looks like the check has caught something real
>>> (http://build.chromium.org/p/**chromium/builders/Linux/**
>>>
builds/23545/steps/check_**licenses/logs/stdio<http://build.chromium.org/p/chromium/builders/Linux/builds/23545/steps/check_licenses/logs/stdio>
>>> ):
>>>
>>>
>>> 'native_client/toolchain/**linux_x86/share/gdb/python/**gdb/prompt.py'
>>> has
>>> non-whitelisted license 'GPL (v3 or later)'
>>> 'native_client/toolchain/**linux_x86/share/gdb/python/**gdb/__init__.py'
>>> has
>>> non-whitelisted license 'GPL (v3 or later)'
>>> 'native_client/toolchain/**linux_x86/share/gdb/python/**gdb/types.py'
>>> has
>>> non-whitelisted license 'GPL (v3 or later)'
>>> 'native_client/toolchain/**linux_x86/share/gdb/python/**gdb/printing.py'
>>> has
>>> non-whitelisted license 'GPL (v3 or later)'
>>>
'native_client/toolchain/**linux_x86/share/gdb/python/**gdb/command/prompt.py'
>>> has
>>> non-whitelisted license 'GPL (v3 or later)'
>>>
'native_client/toolchain/**linux_x86/share/gdb/python/**gdb/command/__init__.py'
>>> has
>>> non-whitelisted license 'GPL (v3 or later)'
>>> 'native_client/toolchain/**linux_x86/share/gdb/python/**
>>> gdb/command/pretty_printers.**py'
>>> has non-whitelisted license 'GPL (v3 or later)'
>>>
'native_client/toolchain/**linux_x86_newlib/share/gdb/**python/gdb/prompt.py'
>>> has
>>> non-whitelisted license 'GPL (v3 or later)'
>>>
'native_client/toolchain/**linux_x86_newlib/share/gdb/**python/gdb/__init__.py'
>>> has
>>> non-whitelisted license 'GPL (v3 or later)'
>>>
'native_client/toolchain/**linux_x86_newlib/share/gdb/**python/gdb/types.py'
>>> has
>>> non-whitelisted license 'GPL (v3 or later)'
>>>
'native_client/toolchain/**linux_x86_newlib/share/gdb/**python/gdb/printing.py'
>>> has
>>> non-whitelisted license 'GPL (v3 or later)'
>>> 'native_client/toolchain/**linux_x86_newlib/share/gdb/**
>>> python/gdb/command/prompt.py'
>>> has non-whitelisted license 'GPL (v3 or later)'
>>> 'native_client/toolchain/**linux_x86_newlib/share/gdb/**
>>> python/gdb/command/__init__.**py'
>>> has non-whitelisted license 'GPL (v3 or later)'
>>> 'native_client/toolchain/**linux_x86_newlib/share/gdb/**
>>> python/gdb/command/pretty_**printers.py'
>>> has non-whitelisted license 'GPL (v3 or later)'
>>>
>>> FAILED
>>>
>>> Please read http://www.chromium.org/**developers/adding-3rd-party-**
>>> libraries<http://www.chromium.org/developers/adding-3rd-party-libraries>
>>> for more info how to handle the failure.
>>>
>>>
>>>
>>>
>>>
>>>
http://codereview.chromium.**org/10170050/<http://codereview.chromium.org/101...
>>>
>>> --
>>> You received this message because you are subscribed to the Google
>>> Groups "Native-Client-Reviews" group.
>>> To post to this group, send email to native-client-reviews@**
>>> googlegroups.com <native-client-reviews@googlegroups.com>.
>>> To unsubscribe from this group, send email to native-client-reviews+**
>>>
unsubscribe@googlegroups.com<native-client-reviews%2Bunsubscribe@googlegroups...
>>> .
>>> For more options, visit this group at http://groups.google.com/**
>>>
group/native-client-reviews?**hl=en<http://groups.google.com/group/native-client-reviews?hl=en>
>>> .
>>>
>>>
>>
>

[khim, 2012-04-29 15:46:54]

On Sun, Apr 29, 2012 at 6:48 PM, Nico Weber <thakis@chromium.org> wrote:

> Please check if it's OK to use gpl3 software at Google (see the page
> linked above) and undo the gdb update if not.
>
We've talked about it two years ago (when we switched from GCC 4.2 to GCC
4.4). You can find COPYING3 file in native_client/toolchain/linux_x86
and native_client/toolchain/linux_x86_newlib subdirectories for this very
reason (and it was there before this directory was even added to Chrome).

GCC is not linked in Chrome and GDB is only used to debug it thus GPLv3 was
deemed acceptable for such used case (besides there are little alternatives
for GDB).

It's just that actual GDB bump took somewhat longer then GCC bump (two
years instead of two months)... I don't know why GPLv3-licensed files
in native_client/toolchain/linux_x86/bin
and native_client/toolchain/linux_x86_newlib/bin are accepted by script
while identically-licensed
files native_client/toolchain/linux_x86/share/gdb/python/gdb
and native_client/toolchain/linux_x86_newlib/share/gdb/python/gdb are
rejected.


> On Apr 29, 2012 2:46 AM, "Victor Khimenko" <khim@chromium.org> wrote:
>
>>
>>
>> On Sun, Apr 29, 2012 at 5:24 AM, Mark Seaborn <mseaborn@chromium.org>wrote:
>>
>>> Evgeny and Andrey added GDB to the NaCl toolchain recently, I think.
>>>
>>> s/added/upgraded/
>>
>> GDB was already there, but it was GDB 6.8 (and used GPLv2+), now it's GDB
>> 7.4 (and uses GPLv3+).
>>
>>
>>> Mark
>>>
>>> On 28 April 2012 18:06, <thakis@chromium.org> wrote:
>>>
>>>> Hi,
>>>>
>>>> this turned check_licenses on the linux clobber builder red. The error
>>>> message
>>>> looks like the check has caught something real
>>>> (http://build.chromium.org/p/**chromium/builders/Linux/**
>>>>
builds/23545/steps/check_**licenses/logs/stdio<http://build.chromium.org/p/chromium/builders/Linux/builds/23545/steps/check_licenses/logs/stdio>
>>>> ):
>>>>
>>>>
>>>> 'native_client/toolchain/**linux_x86/share/gdb/python/**gdb/prompt.py'
>>>> has
>>>> non-whitelisted license 'GPL (v3 or later)'
>>>> 'native_client/toolchain/**linux_x86/share/gdb/python/**gdb/__init__.py'
>>>> has
>>>> non-whitelisted license 'GPL (v3 or later)'
>>>> 'native_client/toolchain/**linux_x86/share/gdb/python/**gdb/types.py'
>>>> has
>>>> non-whitelisted license 'GPL (v3 or later)'
>>>> 'native_client/toolchain/**linux_x86/share/gdb/python/**gdb/printing.py'
>>>> has
>>>> non-whitelisted license 'GPL (v3 or later)'
>>>>
'native_client/toolchain/**linux_x86/share/gdb/python/**gdb/command/prompt.py'
>>>> has
>>>> non-whitelisted license 'GPL (v3 or later)'
>>>>
'native_client/toolchain/**linux_x86/share/gdb/python/**gdb/command/__init__.py'
>>>> has
>>>> non-whitelisted license 'GPL (v3 or later)'
>>>> 'native_client/toolchain/**linux_x86/share/gdb/python/**
>>>> gdb/command/pretty_printers.**py'
>>>> has non-whitelisted license 'GPL (v3 or later)'
>>>>
'native_client/toolchain/**linux_x86_newlib/share/gdb/**python/gdb/prompt.py'
>>>> has
>>>> non-whitelisted license 'GPL (v3 or later)'
>>>>
'native_client/toolchain/**linux_x86_newlib/share/gdb/**python/gdb/__init__.py'
>>>> has
>>>> non-whitelisted license 'GPL (v3 or later)'
>>>>
'native_client/toolchain/**linux_x86_newlib/share/gdb/**python/gdb/types.py'
>>>> has
>>>> non-whitelisted license 'GPL (v3 or later)'
>>>>
'native_client/toolchain/**linux_x86_newlib/share/gdb/**python/gdb/printing.py'
>>>> has
>>>> non-whitelisted license 'GPL (v3 or later)'
>>>> 'native_client/toolchain/**linux_x86_newlib/share/gdb/**
>>>> python/gdb/command/prompt.py'
>>>> has non-whitelisted license 'GPL (v3 or later)'
>>>> 'native_client/toolchain/**linux_x86_newlib/share/gdb/**
>>>> python/gdb/command/__init__.**py'
>>>> has non-whitelisted license 'GPL (v3 or later)'
>>>> 'native_client/toolchain/**linux_x86_newlib/share/gdb/**
>>>> python/gdb/command/pretty_**printers.py'
>>>> has non-whitelisted license 'GPL (v3 or later)'
>>>>
>>>> FAILED
>>>>
>>>> Please read http://www.chromium.org/**developers/adding-3rd-party-**
>>>> libraries<http://www.chromium.org/developers/adding-3rd-party-libraries>
>>>> for more info how to handle the failure.
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
http://codereview.chromium.**org/10170050/<http://codereview.chromium.org/101...
>>>>
>>>> --
>>>> You received this message because you are subscribed to the Google
>>>> Groups "Native-Client-Reviews" group.
>>>> To post to this group, send email to native-client-reviews@**
>>>> googlegroups.com <native-client-reviews@googlegroups.com>.
>>>> To unsubscribe from this group, send email to native-client-reviews+**
>>>>
unsubscribe@googlegroups.com<native-client-reviews%2Bunsubscribe@googlegroups...
>>>> .
>>>> For more options, visit this group at http://groups.google.com/**
>>>>
group/native-client-reviews?**hl=en<http://groups.google.com/group/native-client-reviews?hl=en>
>>>> .
>>>>
>>>>
>>>
>>

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To post to this group, send email to native-client-reviews@googlegroups.com.
To unsubscribe from this group, send email to
native-client-reviews+unsubscribe@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/native-client-reviews?hl=en.

[khim, 2012-04-29 15:46:55]

On Sun, Apr 29, 2012 at 6:48 PM, Nico Weber <thakis@chromium.org> wrote:

> Please check if it's OK to use gpl3 software at Google (see the page
> linked above) and undo the gdb update if not.
>
We've talked about it two years ago (when we switched from GCC 4.2 to GCC
4.4). You can find COPYING3 file in native_client/toolchain/linux_x86
and native_client/toolchain/linux_x86_newlib subdirectories for this very
reason (and it was there before this directory was even added to Chrome).

GCC is not linked in Chrome and GDB is only used to debug it thus GPLv3 was
deemed acceptable for such used case (besides there are little alternatives
for GDB).

It's just that actual GDB bump took somewhat longer then GCC bump (two
years instead of two months)... I don't know why GPLv3-licensed files
in native_client/toolchain/linux_x86/bin
and native_client/toolchain/linux_x86_newlib/bin are accepted by script
while identically-licensed
files native_client/toolchain/linux_x86/share/gdb/python/gdb
and native_client/toolchain/linux_x86_newlib/share/gdb/python/gdb are
rejected.


> On Apr 29, 2012 2:46 AM, "Victor Khimenko" <khim@chromium.org> wrote:
>
>>
>>
>> On Sun, Apr 29, 2012 at 5:24 AM, Mark Seaborn <mseaborn@chromium.org>wrote:
>>
>>> Evgeny and Andrey added GDB to the NaCl toolchain recently, I think.
>>>
>>> s/added/upgraded/
>>
>> GDB was already there, but it was GDB 6.8 (and used GPLv2+), now it's GDB
>> 7.4 (and uses GPLv3+).
>>
>>
>>> Mark
>>>
>>> On 28 April 2012 18:06, <thakis@chromium.org> wrote:
>>>
>>>> Hi,
>>>>
>>>> this turned check_licenses on the linux clobber builder red. The error
>>>> message
>>>> looks like the check has caught something real
>>>> (http://build.chromium.org/p/**chromium/builders/Linux/**
>>>>
builds/23545/steps/check_**licenses/logs/stdio<http://build.chromium.org/p/chromium/builders/Linux/builds/23545/steps/check_licenses/logs/stdio>
>>>> ):
>>>>
>>>>
>>>> 'native_client/toolchain/**linux_x86/share/gdb/python/**gdb/prompt.py'
>>>> has
>>>> non-whitelisted license 'GPL (v3 or later)'
>>>> 'native_client/toolchain/**linux_x86/share/gdb/python/**gdb/__init__.py'
>>>> has
>>>> non-whitelisted license 'GPL (v3 or later)'
>>>> 'native_client/toolchain/**linux_x86/share/gdb/python/**gdb/types.py'
>>>> has
>>>> non-whitelisted license 'GPL (v3 or later)'
>>>> 'native_client/toolchain/**linux_x86/share/gdb/python/**gdb/printing.py'
>>>> has
>>>> non-whitelisted license 'GPL (v3 or later)'
>>>>
'native_client/toolchain/**linux_x86/share/gdb/python/**gdb/command/prompt.py'
>>>> has
>>>> non-whitelisted license 'GPL (v3 or later)'
>>>>
'native_client/toolchain/**linux_x86/share/gdb/python/**gdb/command/__init__.py'
>>>> has
>>>> non-whitelisted license 'GPL (v3 or later)'
>>>> 'native_client/toolchain/**linux_x86/share/gdb/python/**
>>>> gdb/command/pretty_printers.**py'
>>>> has non-whitelisted license 'GPL (v3 or later)'
>>>>
'native_client/toolchain/**linux_x86_newlib/share/gdb/**python/gdb/prompt.py'
>>>> has
>>>> non-whitelisted license 'GPL (v3 or later)'
>>>>
'native_client/toolchain/**linux_x86_newlib/share/gdb/**python/gdb/__init__.py'
>>>> has
>>>> non-whitelisted license 'GPL (v3 or later)'
>>>>
'native_client/toolchain/**linux_x86_newlib/share/gdb/**python/gdb/types.py'
>>>> has
>>>> non-whitelisted license 'GPL (v3 or later)'
>>>>
'native_client/toolchain/**linux_x86_newlib/share/gdb/**python/gdb/printing.py'
>>>> has
>>>> non-whitelisted license 'GPL (v3 or later)'
>>>> 'native_client/toolchain/**linux_x86_newlib/share/gdb/**
>>>> python/gdb/command/prompt.py'
>>>> has non-whitelisted license 'GPL (v3 or later)'
>>>> 'native_client/toolchain/**linux_x86_newlib/share/gdb/**
>>>> python/gdb/command/__init__.**py'
>>>> has non-whitelisted license 'GPL (v3 or later)'
>>>> 'native_client/toolchain/**linux_x86_newlib/share/gdb/**
>>>> python/gdb/command/pretty_**printers.py'
>>>> has non-whitelisted license 'GPL (v3 or later)'
>>>>
>>>> FAILED
>>>>
>>>> Please read http://www.chromium.org/**developers/adding-3rd-party-**
>>>> libraries<http://www.chromium.org/developers/adding-3rd-party-libraries>
>>>> for more info how to handle the failure.
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
http://codereview.chromium.**org/10170050/<http://codereview.chromium.org/101...
>>>>
>>>> --
>>>> You received this message because you are subscribed to the Google
>>>> Groups "Native-Client-Reviews" group.
>>>> To post to this group, send email to native-client-reviews@**
>>>> googlegroups.com <native-client-reviews@googlegroups.com>.
>>>> To unsubscribe from this group, send email to native-client-reviews+**
>>>>
unsubscribe@googlegroups.com<native-client-reviews%2Bunsubscribe@googlegroups...
>>>> .
>>>> For more options, visit this group at http://groups.google.com/**
>>>>
group/native-client-reviews?**hl=en<http://groups.google.com/group/native-client-reviews?hl=en>
>>>> .
>>>>
>>>>
>>>
>>

[Nico, 2012-04-29 16:15:18]

Please follow http://www.chromium.org/developers/adding-3rd-party-libraries
(email open-source-third-party-reviews@google.com to check that the
license change is ok, then update the license check script).

On Sun, Apr 29, 2012 at 8:46 AM, Victor Khimenko <khim@chromium.org> wrote:
>
> On Sun, Apr 29, 2012 at 6:48 PM, Nico Weber <thakis@chromium.org> wrote:
>>
>> Please check if it's OK to use gpl3 software at Google (see the page
>> linked above) and undo the gdb update if not.
>
> We've talked about it two years ago (when we switched from GCC 4.2 to GCC
> 4.4). You can find COPYING3 file in native_client/toolchain/linux_x86
> and native_client/toolchain/linux_x86_newlib subdirectories for this very
> reason (and it was there before this directory was even added to Chrome).
>
> GCC is not linked in Chrome and GDB is only used to debug it thus GPLv3 was
> deemed acceptable for such used case (besides there are little alternatives
> for GDB).
>
> It's just that actual GDB bump took somewhat longer then GCC bump (two years
> instead of two months)... I don't know why GPLv3-licensed files
> in native_client/toolchain/linux_x86/bin
> and native_client/toolchain/linux_x86_newlib/bin are accepted by script
> while identically-licensed
> files native_client/toolchain/linux_x86/share/gdb/python/gdb
> and native_client/toolchain/linux_x86_newlib/share/gdb/python/gdb are
> rejected.
>
>>
>> On Apr 29, 2012 2:46 AM, "Victor Khimenko" <khim@chromium.org> wrote:
>>>
>>>
>>>
>>> On Sun, Apr 29, 2012 at 5:24 AM, Mark Seaborn <mseaborn@chromium.org>
>>> wrote:
>>>>
>>>> Evgeny and Andrey added GDB to the NaCl toolchain recently, I think.
>>>>
>>> s/added/upgraded/
>>>
>>> GDB was already there, but it was GDB 6.8 (and used GPLv2+), now it's GDB
>>> 7.4 (and uses GPLv3+).
>>>
>>>>
>>>> Mark
>>>>
>>>> On 28 April 2012 18:06, <thakis@chromium.org> wrote:
>>>>>
>>>>> Hi,
>>>>>
>>>>> this turned check_licenses on the linux clobber builder red. The error
>>>>> message
>>>>> looks like the check has caught something real
>>>>>
>>>>>
(http://build.chromium.org/p/chromium/builders/Linux/builds/23545/steps/check_...):
>>>>>
>>>>>
>>>>> 'native_client/toolchain/linux_x86/share/gdb/python/gdb/prompt.py' has
>>>>> non-whitelisted license 'GPL (v3 or later)'
>>>>> 'native_client/toolchain/linux_x86/share/gdb/python/gdb/__init__.py'
>>>>> has
>>>>> non-whitelisted license 'GPL (v3 or later)'
>>>>> 'native_client/toolchain/linux_x86/share/gdb/python/gdb/types.py' has
>>>>> non-whitelisted license 'GPL (v3 or later)'
>>>>> 'native_client/toolchain/linux_x86/share/gdb/python/gdb/printing.py'
>>>>> has
>>>>> non-whitelisted license 'GPL (v3 or later)'
>>>>>
>>>>>
'native_client/toolchain/linux_x86/share/gdb/python/gdb/command/prompt.py'
>>>>> has
>>>>> non-whitelisted license 'GPL (v3 or later)'
>>>>>
>>>>>
'native_client/toolchain/linux_x86/share/gdb/python/gdb/command/__init__.py'
>>>>> has
>>>>> non-whitelisted license 'GPL (v3 or later)'
>>>>>
>>>>>
'native_client/toolchain/linux_x86/share/gdb/python/gdb/command/pretty_printers.py'
>>>>> has non-whitelisted license 'GPL (v3 or later)'
>>>>>
>>>>> 'native_client/toolchain/linux_x86_newlib/share/gdb/python/gdb/prompt.py'
>>>>> has
>>>>> non-whitelisted license 'GPL (v3 or later)'
>>>>>
>>>>>
'native_client/toolchain/linux_x86_newlib/share/gdb/python/gdb/__init__.py'
>>>>> has
>>>>> non-whitelisted license 'GPL (v3 or later)'
>>>>>
>>>>> 'native_client/toolchain/linux_x86_newlib/share/gdb/python/gdb/types.py'
has
>>>>> non-whitelisted license 'GPL (v3 or later)'
>>>>>
>>>>>
'native_client/toolchain/linux_x86_newlib/share/gdb/python/gdb/printing.py'
>>>>> has
>>>>> non-whitelisted license 'GPL (v3 or later)'
>>>>>
>>>>>
'native_client/toolchain/linux_x86_newlib/share/gdb/python/gdb/command/prompt.py'
>>>>> has non-whitelisted license 'GPL (v3 or later)'
>>>>>
>>>>>
'native_client/toolchain/linux_x86_newlib/share/gdb/python/gdb/command/__init__.py'
>>>>> has non-whitelisted license 'GPL (v3 or later)'
>>>>>
>>>>>
'native_client/toolchain/linux_x86_newlib/share/gdb/python/gdb/command/pretty_printers.py'
>>>>> has non-whitelisted license 'GPL (v3 or later)'
>>>>>
>>>>> FAILED
>>>>>
>>>>> Please read
>>>>> http://www.chromium.org/developers/adding-3rd-party-libraries
>>>>> for more info how to handle the failure.
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> http://codereview.chromium.org/10170050/
>>>>>
>>>>> --
>>>>> You received this message because you are subscribed to the Google
>>>>> Groups "Native-Client-Reviews" group.
>>>>> To post to this group, send email to
>>>>> native-client-reviews@googlegroups.com.
>>>>> To unsubscribe from this group, send email to
>>>>> native-client-reviews+unsubscribe@googlegroups.com.
>>>>> For more options, visit this group at
>>>>> http://groups.google.com/group/native-client-reviews?hl=en.
>>>>>
>>>>
>>>
>

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To post to this group, send email to native-client-reviews@googlegroups.com.
To unsubscribe from this group, send email to
native-client-reviews+unsubscribe@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/native-client-reviews?hl=en.

[Nico, 2012-04-29 16:15:19]

Please follow http://www.chromium.org/developers/adding-3rd-party-libraries
(email open-source-third-party-reviews@google.com to check that the
license change is ok, then update the license check script).

On Sun, Apr 29, 2012 at 8:46 AM, Victor Khimenko <khim@chromium.org> wrote:
>
> On Sun, Apr 29, 2012 at 6:48 PM, Nico Weber <thakis@chromium.org> wrote:
>>
>> Please check if it's OK to use gpl3 software at Google (see the page
>> linked above) and undo the gdb update if not.
>
> We've talked about it two years ago (when we switched from GCC 4.2 to GCC
> 4.4). You can find COPYING3 file in native_client/toolchain/linux_x86
> and native_client/toolchain/linux_x86_newlib subdirectories for this very
> reason (and it was there before this directory was even added to Chrome).
>
> GCC is not linked in Chrome and GDB is only used to debug it thus GPLv3 was
> deemed acceptable for such used case (besides there are little alternatives
> for GDB).
>
> It's just that actual GDB bump took somewhat longer then GCC bump (two years
> instead of two months)... I don't know why GPLv3-licensed files
> in native_client/toolchain/linux_x86/bin
> and native_client/toolchain/linux_x86_newlib/bin are accepted by script
> while identically-licensed
> files native_client/toolchain/linux_x86/share/gdb/python/gdb
> and native_client/toolchain/linux_x86_newlib/share/gdb/python/gdb are
> rejected.
>
>>
>> On Apr 29, 2012 2:46 AM, "Victor Khimenko" <khim@chromium.org> wrote:
>>>
>>>
>>>
>>> On Sun, Apr 29, 2012 at 5:24 AM, Mark Seaborn <mseaborn@chromium.org>
>>> wrote:
>>>>
>>>> Evgeny and Andrey added GDB to the NaCl toolchain recently, I think.
>>>>
>>> s/added/upgraded/
>>>
>>> GDB was already there, but it was GDB 6.8 (and used GPLv2+), now it's GDB
>>> 7.4 (and uses GPLv3+).
>>>
>>>>
>>>> Mark
>>>>
>>>> On 28 April 2012 18:06, <thakis@chromium.org> wrote:
>>>>>
>>>>> Hi,
>>>>>
>>>>> this turned check_licenses on the linux clobber builder red. The error
>>>>> message
>>>>> looks like the check has caught something real
>>>>>
>>>>>
(http://build.chromium.org/p/chromium/builders/Linux/builds/23545/steps/check_...):
>>>>>
>>>>>
>>>>> 'native_client/toolchain/linux_x86/share/gdb/python/gdb/prompt.py' has
>>>>> non-whitelisted license 'GPL (v3 or later)'
>>>>> 'native_client/toolchain/linux_x86/share/gdb/python/gdb/__init__.py'
>>>>> has
>>>>> non-whitelisted license 'GPL (v3 or later)'
>>>>> 'native_client/toolchain/linux_x86/share/gdb/python/gdb/types.py' has
>>>>> non-whitelisted license 'GPL (v3 or later)'
>>>>> 'native_client/toolchain/linux_x86/share/gdb/python/gdb/printing.py'
>>>>> has
>>>>> non-whitelisted license 'GPL (v3 or later)'
>>>>>
>>>>>
'native_client/toolchain/linux_x86/share/gdb/python/gdb/command/prompt.py'
>>>>> has
>>>>> non-whitelisted license 'GPL (v3 or later)'
>>>>>
>>>>>
'native_client/toolchain/linux_x86/share/gdb/python/gdb/command/__init__.py'
>>>>> has
>>>>> non-whitelisted license 'GPL (v3 or later)'
>>>>>
>>>>>
'native_client/toolchain/linux_x86/share/gdb/python/gdb/command/pretty_printers.py'
>>>>> has non-whitelisted license 'GPL (v3 or later)'
>>>>>
>>>>> 'native_client/toolchain/linux_x86_newlib/share/gdb/python/gdb/prompt.py'
>>>>> has
>>>>> non-whitelisted license 'GPL (v3 or later)'
>>>>>
>>>>>
'native_client/toolchain/linux_x86_newlib/share/gdb/python/gdb/__init__.py'
>>>>> has
>>>>> non-whitelisted license 'GPL (v3 or later)'
>>>>>
>>>>> 'native_client/toolchain/linux_x86_newlib/share/gdb/python/gdb/types.py'
has
>>>>> non-whitelisted license 'GPL (v3 or later)'
>>>>>
>>>>>
'native_client/toolchain/linux_x86_newlib/share/gdb/python/gdb/printing.py'
>>>>> has
>>>>> non-whitelisted license 'GPL (v3 or later)'
>>>>>
>>>>>
'native_client/toolchain/linux_x86_newlib/share/gdb/python/gdb/command/prompt.py'
>>>>> has non-whitelisted license 'GPL (v3 or later)'
>>>>>
>>>>>
'native_client/toolchain/linux_x86_newlib/share/gdb/python/gdb/command/__init__.py'
>>>>> has non-whitelisted license 'GPL (v3 or later)'
>>>>>
>>>>>
'native_client/toolchain/linux_x86_newlib/share/gdb/python/gdb/command/pretty_printers.py'
>>>>> has non-whitelisted license 'GPL (v3 or later)'
>>>>>
>>>>> FAILED
>>>>>
>>>>> Please read
>>>>> http://www.chromium.org/developers/adding-3rd-party-libraries
>>>>> for more info how to handle the failure.
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> http://codereview.chromium.org/10170050/
>>>>>
>>>>> --
>>>>> You received this message because you are subscribed to the Google
>>>>> Groups "Native-Client-Reviews" group.
>>>>> To post to this group, send email to
>>>>> native-client-reviews@googlegroups.com.
>>>>> To unsubscribe from this group, send email to
>>>>> native-client-reviews+unsubscribe@googlegroups.com.
>>>>> For more options, visit this group at
>>>>> http://groups.google.com/group/native-client-reviews?hl=en.
>>>>>
>>>>
>>>
>

[Avi (use Gerrit), 2012-04-30 14:37:59]

On Sun, Apr 29, 2012 at 11:46 AM, Victor Khimenko <khim@chromium.org> wrote:

> I don't know why GPLv3-licensed files
> in native_client/toolchain/linux_x86/bin
> and native_client/toolchain/linux_x86_newlib/bin are accepted by script
> while identically-licensed
> files native_client/toolchain/linux_x86/share/gdb/python/gdb
> and native_client/toolchain/linux_x86_newlib/share/gdb/python/gdb are
> rejected.
>

If you don't understand why, then it's your responsibility to figure it
out. It's unacceptable to land a change that turns a major builder red and
leave the builder burning for two days until the build sheriff comes in on
Monday morning to clean up the mess.

The reason, BTW, is that the license is slightly different in GDB than in
the existing files. I'm extending the whitelist to fix the problem.

Avi