Issue 10170020: Rework chromeos::FlimflamDevice/ServiceClient with CallMethodWithErrorCallback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10170020: Rework chromeos::FlimflamDevice/ServiceClient with CallMethodWithErrorCallback (Closed)

Created:
8 years, 8 months ago by hashimoto

Modified:
8 years, 8 months ago

Reviewers:
satorux1

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Rework chromeos::FlimflamDevice/ServiceClient with CallMethodWithErrorCallback Modify FlimflamDeviceClient's PIN operation methods and Register to use CallMethodWithErrorCallback Modify FlimflamServiceClient::Connect to use CallMethodWithErrorCallback BUG=chromium-os:16557 TEST=chromeos_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133624

Patch Set 1 #

Patch Set 2 : _ #

Patch Set 3 : Rebase #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+220 lines, -49 lines)			Patch
M	chromeos/dbus/flimflam_client_helper.h	View		4 chunks	+19 lines, -0 lines	0 comments	Download
M	chromeos/dbus/flimflam_client_helper.cc	View		2 chunks	+33 lines, -0 lines	0 comments	Download
M	chromeos/dbus/flimflam_client_unittest_base.h	View		3 chunks	+28 lines, -0 lines	0 comments	Download
M	chromeos/dbus/flimflam_client_unittest_base.cc	View	1	3 chunks	+35 lines, -1 line	0 comments	Download
M	chromeos/dbus/flimflam_device_client.h	View		2 chunks	+11 lines, -5 lines	0 comments	Download
M	chromeos/dbus/flimflam_device_client.cc	View		2 chunks	+35 lines, -20 lines	0 comments	Download
M	chromeos/dbus/flimflam_device_client_unittest.cc	View		5 chunks	+25 lines, -5 lines	0 comments	Download
M	chromeos/dbus/flimflam_service_client.h	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	chromeos/dbus/flimflam_service_client.cc	View		2 chunks	+7 lines, -4 lines	0 comments	Download
M	chromeos/dbus/flimflam_service_client_unittest.cc	View		1 chunk	+6 lines, -1 line	0 comments	Download
M	chromeos/dbus/mock_flimflam_device_client.h	View		1 chunk	+15 lines, -10 lines	0 comments	Download
M	chromeos/dbus/mock_flimflam_service_client.h	View		1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

hashimoto

This patch depends on http://codereview.chromium.org/10168027/ ("Add MockObjectProxy::CallMethodWithErrorCallback ")

8 years, 8 months ago (2012-04-23 06:48:52 UTC) #1

LGTM

Expand Messages | Collapse Messages