Issue 10170014: Move text input API to Instance.

Issue 10170014: Move text input API to Instance. (Closed)

Created:
8 years, 8 months ago by brettw

Modified:
8 years, 8 months ago

Reviewers:
Scott Hess - ex-Googler

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move text input API to Instance. This allows us to delete a bunch of separate files that just do routing. TEST=none BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134284

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+246 lines, -467 lines)			Patch
M	ppapi/ppapi_proxy.gypi	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	ppapi/proxy/interface_list.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	ppapi/proxy/ppapi_messages.h	View		1 chunk	+4 lines, -6 lines	0 comments	Download
M	ppapi/proxy/ppb_instance_proxy.h	View		2 chunks	+21 lines, -0 lines	0 comments	Download
M	ppapi/proxy/ppb_instance_proxy.cc	View		21 chunks	+121 lines, -24 lines	0 comments	Download
D	ppapi/proxy/ppb_text_input_proxy.h	View	1	1 chunk	+0 lines, -65 lines	0 comments	Download
M	ppapi/proxy/ppb_text_input_proxy.cc	View	1	1 chunk	+0 lines, -141 lines	0 comments	Download
M	ppapi/shared_impl/function_group_base.h	View		1 chunk	+0 lines, -5 lines	2 comments	Download
M	ppapi/thunk/interfaces_ppb_public_dev.h	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	ppapi/thunk/ppb_instance_api.h	View		2 chunks	+14 lines, -0 lines	0 comments	Download
D	ppapi/thunk/ppb_text_input_api.h	View		1 chunk	+0 lines, -36 lines	0 comments	Download
M	ppapi/thunk/ppb_text_input_thunk.cc	View		3 chunks	+6 lines, -6 lines	0 comments	Download
M	webkit/glue/webkit_glue.gypi	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	webkit/plugins/ppapi/host_globals.cc	View		2 chunks	+0 lines, -4 lines	0 comments	Download
M	webkit/plugins/ppapi/ppapi_plugin_instance.h	View		2 chunks	+13 lines, -10 lines	0 comments	Download
M	webkit/plugins/ppapi/ppapi_plugin_instance.cc	View		3 chunks	+65 lines, -36 lines	0 comments	Download
D	webkit/plugins/ppapi/ppb_text_input_impl.h	View		1 chunk	+0 lines, -49 lines	0 comments	Download
D	webkit/plugins/ppapi/ppb_text_input_impl.cc	View		1 chunk	+0 lines, -77 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Scott Hess - ex-Googler

LGTM. And, by that, I mean that I think I follow what you're doing, and ...

8 years, 8 months ago (2012-04-23 20:48:37 UTC) #2

brettw

8 years, 8 months ago (2012-04-23 22:00:55 UTC) #3

http://codereview.chromium.org/10170014/diff/1002/ppapi/shared_impl/function_...
File ppapi/shared_impl/function_group_base.h (left):

http://codereview.chromium.org/10170014/diff/1002/ppapi/shared_impl/function_...
ppapi/shared_impl/function_group_base.h:16: F(PPB_Fullscreen_FunctionAPI) \
On 2012/04/23 20:48:37, shess wrote:
> I guess these were lame ducks?

Yes.

Expand Messages | Collapse Messages