Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Issue 10169044: Draw panel titlebars on Aura. (Closed)

Created:
8 years, 8 months ago by dcheng
Modified:
8 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, ben+watch_chromium.org, Dmitry Titov
Visibility:
Public.

Description

Draw panel titlebars on Aura. Since panel windows aren't transparent, we didn't draw anything so the titlebars for panels were black with buttons drawn on top. BUG=none TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133891

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M ash/wm/frame_painter.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
dcheng
I noticed this when tinkering around with panels to implement some of the other UI ...
8 years, 8 months ago (2012-04-25 00:07:40 UTC) #1
sky
LGTM
8 years, 8 months ago (2012-04-25 03:39:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/10169044/1
8 years, 8 months ago (2012-04-25 09:17:28 UTC) #3
commit-bot: I haz the power
8 years, 8 months ago (2012-04-25 10:45:10 UTC) #4
Change committed as 133891

Powered by Google App Engine
This is Rietveld 408576698