Issue 10169038: ash: Fix missing launcher icon regression.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10169038: ash: Fix missing launcher icon regression. (Closed)

Created:
8 years, 8 months ago by xiyuan

Modified:
8 years, 8 months ago

Reviewers:
sky

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

ash: Fix missing launcher icon regression. The regression is introduced in r133603 where we use opacity to hide newly added view but did not restore it properly on animation cancellation, which happens when adding launcher item before animation finishes. BUG=124855 TEST=Verify fix for issue 124855. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133853

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -4 lines)			Patch
	M	ash/launcher/launcher_view.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	ash/launcher/launcher_view_unittest.cc	View		2 chunks	+36 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/10169038/1

8 years, 8 months ago (2012-04-25 00:13:05 UTC) #3

Change committed as 133853

Expand Messages | Collapse Messages