Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 10169034: Fix an error in gclient revert where a directory is unexpected and locked (Closed)

Created:
8 years, 8 months ago by M-A Ruel
Modified:
8 years, 8 months ago
Reviewers:
cmp
CC:
chromium-reviews, Dirk Pranke, M-A Ruel
Visibility:
Public.

Description

Fix an error in gclient revert where a directory is unexpected and locked This would spurious try job failures because the gclient revert step would throw an exception. R=cmp@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133799

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M scm.py View 1 chunk +5 lines, -0 lines 0 comments Download
M tests/gclient_scm_test.py View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
M-A Ruel
It would generate exceptions looking like that: Traceback (most recent call last): File "depot_tools/gclient.py", line ...
8 years, 8 months ago (2012-04-24 18:48:45 UTC) #1
cmp
lgtm
8 years, 8 months ago (2012-04-24 22:05:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/10169034/1
8 years, 8 months ago (2012-04-24 23:08:48 UTC) #3
commit-bot: I haz the power
8 years, 8 months ago (2012-04-24 23:16:31 UTC) #4
Change committed as 133799

Powered by Google App Engine
This is Rietveld 408576698