Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(776)

Side by Side Diff: chrome/browser/resources/options2/options_page.js

Issue 10169024: fix settings page crashes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 cr.define('options', function() { 5 cr.define('options', function() {
6 ///////////////////////////////////////////////////////////////////////////// 6 /////////////////////////////////////////////////////////////////////////////
7 // OptionsPage class: 7 // OptionsPage class:
8 8
9 /** 9 /**
10 * Base class for options page. 10 * Base class for options page.
(...skipping 605 matching lines...) Expand 10 before | Expand all | Expand 10 after
616 }; 616 };
617 617
618 /** 618 /**
619 * Re-initializes the C++ handlers if necessary. This is called if the 619 * Re-initializes the C++ handlers if necessary. This is called if the
620 * handlers are torn down and recreated but the DOM may not have been (in 620 * handlers are torn down and recreated but the DOM may not have been (in
621 * which case |initialize| won't be called again). If |initialize| hasn't been 621 * which case |initialize| won't be called again). If |initialize| hasn't been
622 * called, this does nothing (since it will be later, once the DOM has 622 * called, this does nothing (since it will be later, once the DOM has
623 * finished loading). 623 * finished loading).
624 */ 624 */
625 OptionsPage.reinitializeCore = function() { 625 OptionsPage.reinitializeCore = function() {
626 if (!this.initialized_) 626 if (this.initialized_)
627 chrome.send('coreOptionsInitialize'); 627 chrome.send('coreOptionsInitialize');
628 }; 628 };
629 629
630 OptionsPage.prototype = { 630 OptionsPage.prototype = {
631 __proto__: cr.EventTarget.prototype, 631 __proto__: cr.EventTarget.prototype,
632 632
633 /** 633 /**
634 * The parent page of this option page, or null for top-level pages. 634 * The parent page of this option page, or null for top-level pages.
635 * @type {OptionsPage} 635 * @type {OptionsPage}
636 */ 636 */
(...skipping 238 matching lines...) Expand 10 before | Expand all | Expand 10 after
875 canShowPage: function() { 875 canShowPage: function() {
876 return true; 876 return true;
877 }, 877 },
878 }; 878 };
879 879
880 // Export 880 // Export
881 return { 881 return {
882 OptionsPage: OptionsPage 882 OptionsPage: OptionsPage
883 }; 883 };
884 }); 884 });
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698