fix settings page crashes

fix settings page crashes

a more intricate fix is on the way, see http://codereview.chromium.org/10154004/

for now this fixes the vast majority of crashes and is easy to merge to m19.

BUG=123705
TEST=manual


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133524

[Tyler Breisacher (Chromium), 2012-04-20 23:52:10]

This is a really easy mistake to make, much like when you see this pattern

do {
  // ...
} while (elem = elem.parentElement);

you might be tempted to change the = to ==.

Do you think it's worth adding a comment that says in big flashing letters, "I
know this looks wrong, but it's not. I promise. Really. Don't change it."?

[Evan Stade, 2012-04-21 00:22:08]

On 2012/04/20 23:52:10, Tyler Breisacher wrote:
> This is a really easy mistake to make, much like when you see this pattern
> 
> do {
>   // ...
> } while (elem = elem.parentElement);
> 
> you might be tempted to change the = to ==.
> 
> Do you think it's worth adding a comment that says in big flashing letters, "I
> know this looks wrong, but it's not. I promise. Really. Don't change it."?

that's what the comment does say

[Evan Stade, 2012-04-21 00:22:41]

(anyway, the entire function is probably going away soon)

[Tyler Breisacher (Chromium), 2012-04-21 00:27:24]

Mmmk cool. lgtm

[commit-bot: I haz the power, 2012-04-23 20:21:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/estade@chromium.org/10169024/1

[Dan Beam, 2012-04-23 21:29:35]

lgtm, sorry again about this

[commit-bot: I haz the power, 2012-04-23 21:43:39]

Change committed as 133524