Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1122)

Issue 10169022: ifdef'd out more references to TaskManager (Closed)

Created:
8 years, 8 months ago by Jesse Greenwald
Modified:
8 years, 8 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, Aaron Boodman, mihaip+watch_chromium.org
Visibility:
Public.

Description

ifdef'd out more references to TaskManager This is working towards getting unit_tests linking for Android platform. BUG=117407 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133506

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M chrome/browser/extensions/extension_processes_api.cc View 3 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Jesse Greenwald
yoz - can you take a look at this change? Thanks,
8 years, 8 months ago (2012-04-20 22:39:30 UTC) #1
Yoyo Zhou
What's your plan for TaskManagerModelObserver? If you are going to ifdef out that class's definition, ...
8 years, 8 months ago (2012-04-20 23:11:47 UTC) #2
Jesse Greenwald
I wasn't planning on doing anything with TaskManagerModelObserver. I'm pretty much just playing whack-a-mole with ...
8 years, 8 months ago (2012-04-20 23:30:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jgreenwald@chromium.org/10169022/1
8 years, 8 months ago (2012-04-23 18:54:53 UTC) #4
commit-bot: I haz the power
8 years, 8 months ago (2012-04-23 20:20:49 UTC) #5
Change committed as 133506

Powered by Google App Engine
This is Rietveld 408576698