Issue 10169014: Parse and store Wifi bssid and frequency properites.

Issue 10169014: Parse and store Wifi bssid and frequency properites. (Closed)

Created:
8 years, 8 months ago by stevenjb

Modified:
8 years, 8 months ago

Reviewers:
Greg Spencer (Chromium), kevers

CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
http://git.chromium.org/git/chromium/src@master

Visibility:
Public.

More Reviews

Description

Parse and store Wifi bssid and frequency properites. Change-Id: Iadd9a6202f0b09e7d3f4171ae7341b2cd8e6e63a BUG=chromium-os:28616, chromium-os:19569 TEST=Will be tested with implementation of chromium-os:19569 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133541

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix test. #

Patch Set 3 : Provide TestApi for SetSsid/SetHexSsid #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -13 lines)			Patch
M	chrome/browser/chromeos/cros/native_network_parser.cc	View		3 chunks	+22 lines, -8 lines	0 comments	Download
M	chrome/browser/chromeos/cros/network_library.h	View	1 2	6 chunks	+18 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/cros/network_library.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/cros/network_library_unittest.cc	View	1 2	3 chunks	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

stevenjb

http://codereview.chromium.org/10169014/diff/1/chrome/browser/chromeos/cros/native_network_parser.cc File chrome/browser/chromeos/cros/native_network_parser.cc (left): http://codereview.chromium.org/10169014/diff/1/chrome/browser/chromeos/cros/native_network_parser.cc#oldcode1075 chrome/browser/chromeos/cros/native_network_parser.cc:1075: value.GetAsBoolean(&passphrase_required); Happened to notice this extra get here...

8 years, 8 months ago (2012-04-20 19:15:34 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/10169014/1

8 years, 8 months ago (2012-04-20 20:19:40 UTC) #3

commit-bot: I haz the power

Try job failure for 10169014-1 (retry) on linux_chromeos for step "compile" (clobber build). It's a ...

8 years, 8 months ago (2012-04-20 21:03:28 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/10169014/5002

8 years, 8 months ago (2012-04-23 20:58:49 UTC) #5

Change committed as 133541

Expand Messages | Collapse Messages