Adds an automation hook WaitUntilNavigationCompletes() which blocks until pending navigation comple…

Adds an automation hook WaitUntilNavigationCompletes() which blocks until pending navigation completes.

Once this call returns it is safe to call the ExecuteJavascript() family of automation hooks.

BUG=124438
TEST=functional/apptest.py


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133499

[dennis_jeffrey, 2012-04-20 22:11:32]

https://chromiumcodereview.appspot.com/10168019/diff/4001/chrome/browser/auto...
File chrome/browser/automation/testing_automation_provider.cc (right):

https://chromiumcodereview.appspot.com/10168019/diff/4001/chrome/browser/auto...
chrome/browser/automation/testing_automation_provider.cc:6360: }
possible race condition here?  The check above could return false because the
page is loading, but then the page may stop loading before the observer below is
ready to listen for the page to stop loading

https://chromiumcodereview.appspot.com/10168019/diff/4001/chrome/test/pyautol...
File chrome/test/pyautolib/pyauto.py (right):

https://chromiumcodereview.appspot.com/10168019/diff/4001/chrome/test/pyautol...
chrome/test/pyautolib/pyauto.py:3131: 'windex' : windex,
remove space before the ":" in the above 2 lines

[craigdh, 2012-04-20 23:04:55]

Dennis: Please look and make sure my solution to the race condition seems right
to you.

https://chromiumcodereview.appspot.com/10168019/diff/4001/chrome/browser/auto...
File chrome/browser/automation/testing_automation_provider.cc (right):

https://chromiumcodereview.appspot.com/10168019/diff/4001/chrome/browser/auto...
chrome/browser/automation/testing_automation_provider.cc:6360: }
On 2012/04/20 22:11:32, dennis_jeffrey wrote:
> possible race condition here?  The check above could return false because the
> page is loading, but then the page may stop loading before the observer below
is
> ready to listen for the page to stop loading

Yes, you're right. Somehow I thought I had avoided that. This new changelist
should fix it.

[dennis_jeffrey, 2012-04-20 23:14:11]

LGTM

[Nirnimesh, 2012-04-23 18:23:15]

LGTM

[commit-bot: I haz the power, 2012-04-23 18:24:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/craigdh@chromium.org/10168019/8001

[commit-bot: I haz the power, 2012-04-23 19:44:37]

Change committed as 133499