chrome/browser/password_manager/password_manager.h - Issue 10168017: Only enable password generation if password manager and autofill are both

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/password_manager.h

Issue 10168017: Only enable password generation if password manager and autofill are both (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove autofill requirement Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/autofill/autofill_manager.cc ('K') | « chrome/browser/autofill/autofill_manager_unittest.cc ('k') | chrome/browser/password_manager/password_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/password_manager.h

diff --git a/chrome/browser/password_manager/password_manager.h b/chrome/browser/password_manager/password_manager.h

index 8b386d4dbddad9a2be1b81250b9ce9ffaf9c24bc..86dba4ec1b4b7830b91b47d71b8d39e3ef57b501 100644

--- a/chrome/browser/password_manager/password_manager.h

+++ b/chrome/browser/password_manager/password_manager.h

@@ -37,6 +37,9 @@ class PasswordManager : public LoginModel,

PasswordManagerDelegate* delegate);

virtual ~PasswordManager();

+ // Is password autofill enabled for the current profile?

+ bool IsEnabled() const;

// Called by a PasswordFormManager when it decides a form can be autofilled

// on the page.

void Autofill(const webkit::forms::PasswordForm& form_for_autofill,

@@ -82,9 +85,6 @@ class PasswordManager : public LoginModel,

// When a form is "seen" on a page, a PasswordFormManager is created

// and stored in this collection until user navigates away from page.

- // Is password autofill enabled for the current profile?

- bool IsEnabled() const;

ScopedVector<PasswordFormManager> pending_login_managers_;

// When the user submits a password/credential, this contains the