Only enable password generation if password manager and autofill are both

chrome/browser/password_manager/password_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_MANAGER_H_
 #define CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_MANAGER_H_
 #pragma once
 
 #include <vector>
 
@@ skipping 19 matching lines @@
 class PasswordManager : public LoginModel,
                         public content::WebContentsObserver {
  public:
   static void RegisterUserPrefs(PrefService* prefs);
 
   // The delegate passed in is required to outlive the PasswordManager.
   PasswordManager(content::WebContents* web_contents,
                   PasswordManagerDelegate* delegate);
   virtual ~PasswordManager();
 
+  // Is password autofill enabled for the current profile?
+  bool IsEnabled() const;

[Ilya Sherman, 2012/04/24 00:46:54]

nit: Please move this function's definition within the implementation file as
well.

[Garrett Casto, 2012/04/24 18:49:56]

Done.

+
   // Called by a PasswordFormManager when it decides a form can be autofilled
   // on the page.
   void Autofill(const webkit::forms::PasswordForm& form_for_autofill,
                 const webkit::forms::PasswordFormMap& best_matches,
                 const webkit::forms::PasswordForm& preferred_match,
                 bool wait_for_username) const;
 
   // LoginModel implementation.
   virtual void SetObserver(LoginModelObserver* observer) OVERRIDE;
 
@@ skipping 25 matching lines @@
   //       |                                             new
   //       |                                               ___ Infobar
   // pending_login -- form submit --> provisional_save ___/
   //             ^                            |           \___ (update DB)
   //             |                           fail
   //             |-----------<------<---------|          !new
   //
   // When a form is "seen" on a page, a PasswordFormManager is created
   // and stored in this collection until user navigates away from page.
 
-  // Is password autofill enabled for the current profile?
-  bool IsEnabled() const;
-
   ScopedVector<PasswordFormManager> pending_login_managers_;
 
   // When the user submits a password/credential, this contains the
   // PasswordFormManager for the form in question until we deem the login
   // attempt to have succeeded (as in valid credentials). If it fails, we
   // send the PasswordFormManager back to the pending_login_managers_ set.
   // Scoped in case PasswordManager gets deleted (e.g tab closes) between the
   // time a user submits a login form and gets to the next page.
   scoped_ptr<PasswordFormManager> provisional_save_manager_;
 
   // Our delegate for carrying out external operations.  This is typically the
   // containing WebContents.
   PasswordManagerDelegate* const delegate_;
 
   // The LoginModelObserver (i.e LoginView) requiring autofill.
   LoginModelObserver* observer_;
 
   // Set to false to disable the password manager (will no longer fill
   // passwords or ask you if you want to save passwords).
   BooleanPrefMember password_manager_enabled_;
 
   DISALLOW_COPY_AND_ASSIGN(PasswordManager);
 };
 
 #endif  // CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_MANAGER_H_