Issue 10168015: [Coverity] Fixed resource leak.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10168015: [Coverity] Fixed resource leak. (Closed)

Created:
8 years, 8 months ago by groby-ooo-7-16

Modified:
8 years, 8 months ago

Reviewers:
brettw, raymes

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

[Coverity] Fixed resource leak. DeepCopy creates a ListValue*, which swap (correctly) doesn't free. CID=103840 R=brettw,raymes BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133478

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	ppapi/shared_impl/private/ppb_x509_certificate_private_shared.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 5 (0 generated)

groby-ooo-7-16

brettw: OWNERS raymes: Could you double check I didn't mix up what you intended to ...

8 years, 8 months ago (2012-04-20 20:29:26 UTC) #1

raymes

LGTM Thanks, this is subtle. On Fri, Apr 20, 2012 at 1:35 PM, <brettw@chromium.org> wrote: ...

8 years, 8 months ago (2012-04-20 20:47:53 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/10168015/1

8 years, 8 months ago (2012-04-23 16:49:51 UTC) #4

Change committed as 133478