Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/status_icons/desktop_notification_balloon.cc

Issue 10168008: Show camera and microphone status indicators. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: addressed Tommi's comments. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/media/media_stream_capture_indicator.cc ('K') | « chrome/browser/media/media_stream_capture_indicator.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/status_icons/desktop_notification_balloon.cc
diff --git a/chrome/browser/status_icons/desktop_notification_balloon.cc b/chrome/browser/status_icons/desktop_notification_balloon.cc
index a0361d4eb66cfd1fd40cb314fa0ce07a41fccf2f..fe0c4787b97a05c5182768a90a7056a02a00d4a1 100644
--- a/chrome/browser/status_icons/desktop_notification_balloon.cc
+++ b/chrome/browser/status_icons/desktop_notification_balloon.cc
@@ -19,6 +19,11 @@
namespace {
void CloseBalloon(const std::string& id) {
+ // The browser process may have gone away during shutting down, in this case
Nico 2012/04/25 15:52:51 nit: "during shutdown"
no longer working on chromium 2012/04/30 09:59:38 Done.
+ // notification_ui_manager() will close the balloon in its destructor.
+ if (!g_browser_process)
+ return;
+
g_browser_process->notification_ui_manager()->CancelById(id);
}
« chrome/browser/media/media_stream_capture_indicator.cc ('K') | « chrome/browser/media/media_stream_capture_indicator.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698