WebSocket Pepper API: PPB_WebSocket::close must accept undefined reason

WebSocket Pepper API: PPB_WebSocket::close must accept undefined reason

IDL defines close behavior as it ignores the reason argument if the type of
reason is PP_VARTYPE_UNDEFINED.

BUG=124609
TEST=browser_tests --gtest_filter='*WebSocket*'


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133646

[Takashi Toyoshima, 2012-04-23 11:29:54]

Hi David,
A user reports a problematic behavior which doesn't conform IDL definition.
I fixed it. Could you review this change?

[dmichael (off chromium), 2012-04-23 15:14:46]

lgtm

http://codereview.chromium.org/10167028/diff/3003/ppapi/tests/test_websocket.cc
File ppapi/tests/test_websocket.cc (right):

http://codereview.chromium.org/10167028/diff/3003/ppapi/tests/test_websocket....
ppapi/tests/test_websocket.cc:535: PP_WEBSOCKETSTATUSCODE_NORMAL_CLOSURE,
PP_MakeUndefined(),
For what it's worth, I don't think supporting Undefined matters as much for
Pepper as it does for JavaScript, since the parameter is required anyway for
pepper. In JavaScript you could completely omit it. But it seems fine to support
it as you have.

http://codereview.chromium.org/10167028/diff/3003/webkit/plugins/ppapi/ppb_we...
File webkit/plugins/ppapi/ppb_websocket_impl.cc (right):

http://codereview.chromium.org/10167028/diff/3003/webkit/plugins/ppapi/ppb_we...
webkit/plugins/ppapi/ppb_websocket_impl.cc:232: // surrogates.
I'm not sure what you mean here, but I'm guessing it suffices to check that the
string is valid UTF-8? VarFromUTF8 does that, so by the time you get the PP_Var,
it's already validated. I think you can remove this comment.

[Takashi Toyoshima, 2012-04-24 06:44:56]

Thank you.
I removed obsolete TODO before landing.

http://codereview.chromium.org/10167028/diff/3003/ppapi/tests/test_websocket.cc
File ppapi/tests/test_websocket.cc (right):

http://codereview.chromium.org/10167028/diff/3003/ppapi/tests/test_websocket....
ppapi/tests/test_websocket.cc:535: PP_WEBSOCKETSTATUSCODE_NORMAL_CLOSURE,
PP_MakeUndefined(),
Actually, code and reason arguments are optional not only for JavaScript API,
but also wireframe protocol. The difference can be seen from a server. I wil
make another change to define a constant to omit status code.

http://codereview.chromium.org/10167028/diff/3003/webkit/plugins/ppapi/ppb_we...
File webkit/plugins/ppapi/ppb_websocket_impl.cc (right):

http://codereview.chromium.org/10167028/diff/3003/webkit/plugins/ppapi/ppb_we...
webkit/plugins/ppapi/ppb_websocket_impl.cc:232: // surrogates.
Thank you.
I check VarFromUTF8 implementation. As you said, it includes surrogates check.

FYI; Surrogate pair is defined in UTF-16 to expand the number of characters in
16-bit. It means UTF-16 has multi-word characters. These pairs consist of
special characters from 0xd800 to 0xdfff. UTF-8 must not include these codes
after it is decoded to Unicode.

[commit-bot: I haz the power, 2012-04-24 06:45:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/toyoshim@chromium.org/10167028/11001

[commit-bot: I haz the power, 2012-04-24 08:06:54]

Change committed as 133646