Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2704)

Unified Diff: chrome/browser/sync/test/integration/migration_errors_test.cc

Issue 10167017: Fix some migration-related bugs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Review changes Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/profile_sync_service.cc ('k') | sync/sessions/sync_session.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/test/integration/migration_errors_test.cc
diff --git a/chrome/browser/sync/test/integration/migration_errors_test.cc b/chrome/browser/sync/test/integration/migration_errors_test.cc
index 10acde37f2af32794c1dad7509bb22647ea52b1b..abfca57024fac90034918ee322ec446207f9b69b 100644
--- a/chrome/browser/sync/test/integration/migration_errors_test.cc
+++ b/chrome/browser/sync/test/integration/migration_errors_test.cc
@@ -251,13 +251,15 @@ IN_PROC_BROWSER_TEST_F(MigrationSingleClientTest, BookmarksPrefsBoth) {
// Two data types with one being nigori.
-IN_PROC_BROWSER_TEST_F(MigrationSingleClientTest, PrefsNigoriIndividiaully) {
+IN_PROC_BROWSER_TEST_F(MigrationSingleClientTest,
+ DISABLED_PrefsNigoriIndividiaully) {
RunSingleClientMigrationTest(
MakeList(syncable::PREFERENCES, syncable::NIGORI),
TRIGGER_NOTIFICATION);
}
-IN_PROC_BROWSER_TEST_F(MigrationSingleClientTest, PrefsNigoriBoth) {
+// TODO(rlarocque): Re-enable this test when crbug.com/122033 is fixed.
+IN_PROC_BROWSER_TEST_F(MigrationSingleClientTest, DISABLED_PrefsNigoriBoth) {
RunSingleClientMigrationTest(
MakeList(MakeSet(syncable::PREFERENCES, syncable::NIGORI)),
MODIFY_PREF);
@@ -293,14 +295,16 @@ IN_PROC_BROWSER_TEST_F(MigrationSingleClientTest,
// All data types plus nigori.
IN_PROC_BROWSER_TEST_F(MigrationSingleClientTest,
- AllTypesWithNigoriIndividually) {
+ DISABLED_AllTypesWithNigoriIndividually) {
ASSERT_TRUE(SetupClients());
MigrationList migration_list = GetPreferredDataTypesList();
migration_list.push_front(MakeSet(syncable::NIGORI));
RunSingleClientMigrationTest(migration_list, MODIFY_BOOKMARK);
}
-IN_PROC_BROWSER_TEST_F(MigrationSingleClientTest, AllTypesWithNigoriAtOnce) {
+// TODO(rlarocque): Re-enable this test when crbug.com/122033 is fixed.
+IN_PROC_BROWSER_TEST_F(MigrationSingleClientTest,
+ DISABLED_AllTypesWithNigoriAtOnce) {
ASSERT_TRUE(SetupClients());
syncable::ModelTypeSet all_types = GetPreferredDataTypes();
all_types.Put(syncable::NIGORI);
@@ -374,7 +378,9 @@ IN_PROC_BROWSER_TEST_F(MigrationTwoClientTest, MigrationHellWithoutNigori) {
RunTwoClientMigrationTest(migration_list, MODIFY_BOOKMARK);
}
-IN_PROC_BROWSER_TEST_F(MigrationTwoClientTest, MigrationHellWithNigori) {
+// TODO(rlarocque) Re-enable this test when crbug.com/122033 is fixed.
+IN_PROC_BROWSER_TEST_F(MigrationTwoClientTest,
+ DISABLED_MigrationHellWithNigori) {
ASSERT_TRUE(SetupClients());
MigrationList migration_list = GetPreferredDataTypesList();
// Let the first nudge be a datatype that's neither prefs nor
« no previous file with comments | « chrome/browser/sync/profile_sync_service.cc ('k') | sync/sessions/sync_session.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698