Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Issue 10166018: Convert a few more NMF files to be autogenerated and PNaCl (Closed)

Created:
8 years, 8 months ago by jvoung - send to chromium...
Modified:
8 years, 8 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Convert a few more NMF files to be autogenerated and PNaCl compatible, even though they are currently marked broken for PNaCl. Bail out for partly_invalid, since: - that depends on a nexe built from a nacl.scons file in NaCl repo and - the nexe name doesn't follow the autogenerator's pattern - and the nacl repo's pyauto expects the .nmf Can untie those dependencies later... This will allow use to run ./scons bitcode=1 platform=${arch} again, without complaints about missing .nexe dependencies required by the checked-in NMF files, even though we are generating .pexes. BUG= http://code.google.com/p/nativeclient/issues/detail?id=2609 TEST= trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133327

Patch Set 1 #

Patch Set 2 : Cannot autogenerate partly_invalid yet... dependency mess #

Total comments: 1

Messages

Total messages: 5 (0 generated)
jvoung - send to chromium...
Nicholas, do you know if we can just delete the ppapi_gles_book files? http://codereview.chromium.org/10166018/diff/1011/ppapi/native_client/tests/ppapi_gles_book/nacl.scons File ppapi/native_client/tests/ppapi_gles_book/nacl.scons ...
8 years, 8 months ago (2012-04-20 23:15:15 UTC) #1
Mark Seaborn
LGTM
8 years, 8 months ago (2012-04-20 23:30:41 UTC) #2
nfullagar
I don't think we should delete the ppapi_example_gles2 examples.
8 years, 8 months ago (2012-04-20 23:47:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jvoung@google.com/10166018/1011
8 years, 8 months ago (2012-04-21 00:19:34 UTC) #4
commit-bot: I haz the power
8 years, 8 months ago (2012-04-21 02:26:03 UTC) #5
Change committed as 133327

Powered by Google App Engine
This is Rietveld 408576698