Issue 10166015: Implement sourceAddId() & sourceRemoveId()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10166015: Implement sourceAddId() & sourceRemoveId() (Closed)

Created:
8 years, 8 months ago by acolwell GONE FROM CHROMIUM

Modified:
8 years, 8 months ago

Reviewers:

CC:
chromium-reviews, feature-media-reviews_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Update MediaSource API implementation to match v0.4 spec. - Adding support for sourceAddId() & sourceRemoveId(). - Adding id parameter to sourceAppend() signature. BUG=122897 TEST=Covered by LayoutTests TBR=scherkus@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133335

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+155 lines, -22 lines)			Patch
M	media/filters/chunk_demuxer.h	View	4 chunks	+26 lines, -3 lines	0 comments	Download
M	media/filters/chunk_demuxer.cc	View	2 chunks	+36 lines, -3 lines	0 comments	Download
M	media/filters/chunk_demuxer_unittest.cc	View	12 chunks	+29 lines, -7 lines	0 comments	Download
M	media/filters/pipeline_integration_test.cc	View	3 chunks	+8 lines, -1 line	0 comments	Download
M	webkit/media/webmediaplayer_impl.h	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	webkit/media/webmediaplayer_impl.cc	View	1 chunk	+29 lines, -1 line	0 comments	Download
M	webkit/media/webmediaplayer_proxy.h	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	webkit/media/webmediaplayer_proxy.cc	View	1 chunk	+15 lines, -6 lines	0 comments	Download

Total messages: 3 (0 generated)

acolwell GONE FROM CHROMIUM

Third time's a charm. Original review was here http://codereview.chromium.org/10066019/

8 years, 8 months ago (2012-04-20 21:13:30 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/10166015/1

8 years, 8 months ago (2012-04-20 23:57:51 UTC) #2

Change committed as 133335