Issue 10166004: Added a message that suggest to configure a proxy for a network.

Issue 10166004: Added a message that suggest to configure a proxy for a network. (Closed)

Created:
8 years, 8 months ago by ygorshenin1

Modified:
8 years, 8 months ago

Reviewers:
Nikita (slow)

CC:
chromium-reviews, arv (Not doing code reviews), nkostylev+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Added a message that suggest to configure a proxy for a network. BUG=chromium:122422 TEST=Manual testing on an Alex device. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133917

Patch Set 2 : Fixed suggestion. #

Total comments: 1

Patch Set 3 : Simplified proxy dialog show. #

Patch Set 4 : Fixed error message. #

Patch Set 6 : Added a custom style for the label on the error screen. #

Patch Set 7 : Fixed license header. #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -8 lines)			Patch
M	chrome/app/generated_resources.grd	View		2 chunks	+10 lines, -1 line	0 comments	Download
M	chrome/browser/resources/chromeos/login/oobe.css	View	1 2 3 4 5	2 chunks	+10 lines, -1 line	0 comments	Download
M	chrome/browser/resources/chromeos/login/screen_error_message.css	View	1 2 3	2 chunks	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/chromeos/login/screen_error_message.html	View	1 2 3 4 5	1 chunk	+6 lines, -5 lines	0 comments	Download
M	chrome/browser/resources/chromeos/login/screen_error_message.js	View	1	2 chunks	+11 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/chromeos/login/network_dropdown_handler.cc	View	1 2 3 4 5 6	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc	View	1 2	4 chunks	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Nikita (slow)

lgtm http://codereview.chromium.org/10166004/diff/3001/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc File chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc (right): http://codereview.chromium.org/10166004/diff/3001/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc#newcode980 chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc:980: ProxySettingsDialog* dialog = #include "chrome/browser/chromeos/login/base_login_display_host.h" BaseLoginDisplayHost::default_host()->OpenProxySettings();

8 years, 8 months ago (2012-04-20 15:09:16 UTC) #2

ygorshenin1

Link to a screenshot: www/~ygorshenin/screenshot-20120424-063302.png Nikita, could you please take another look on chrome/browser/* part ...

8 years, 8 months ago (2012-04-25 07:14:15 UTC) #3

Nikita (slow)

lgtm with these comments addressed http://codereview.chromium.org/10166004/diff/15001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): http://codereview.chromium.org/10166004/diff/15001/chrome/app/generated_resources.grd#newcode12595 chrome/app/generated_resources.grd:12595: + <message name="IDS_ANOTHER_NETWORK_SELECTION_SELECT" desc="Label ...

8 years, 8 months ago (2012-04-25 10:29:50 UTC) #4

ygorshenin1

Thanks, custom style for the label is added. http://codereview.chromium.org/10166004/diff/15001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): http://codereview.chromium.org/10166004/diff/15001/chrome/app/generated_resources.grd#newcode12595 chrome/app/generated_resources.grd:12595: + ...

8 years, 8 months ago (2012-04-25 13:53:13 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/10166004/17002

8 years, 8 months ago (2012-04-25 13:58:03 UTC) #6

Change committed as 133917

Expand Messages | Collapse Messages