Move RefCountedStaticMemory to base namespace

Move RefCountedStaticMemory to base namespace

BUG=none
TEST=compiles

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133702

[simonhong_, 2012-04-20 23:53:46]

Dear joth, erg
Please review this patch.
Thank you.

[joth, 2012-04-21 10:12:43]

lgtm

[simonhong_, 2012-04-22 04:17:35]

On 2012/04/21 10:12:43, joth wrote:
> lgtm

Dear brettw, ben
Please review this issue.

brettw:
  base/*
  chrome/*
ben:
  ui/base/*

Thank you.

[sokoi, 2012-04-22 11:41:51]

lgtm

[commit-bot: I haz the power, 2012-04-22 12:10:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/simon.hong81@gmail.com/10165020/11002

[commit-bot: I haz the power, 2012-04-22 12:10:58]

Presubmit check for 10165020-11002 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/ui/webui/print_preview
    chrome/browser/ui/webui/ntp
    chrome/browser/ui/webui
    base
    ui
    chrome/browser/printing/cloud_print
    chrome/browser/ui/webui/options2

Presubmit checks took 2.4s to calculate.

[Ben Goodger (Google), 2012-04-23 15:27:43]

LGTM thanks for the cleanup.

[Elliot Glaysher, 2012-04-23 17:30:59]

lgtm

[brettw, 2012-04-23 17:50:01]

lgtm

[commit-bot: I haz the power, 2012-04-23 17:52:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/simon.hong81@gmail.com/10165020/11002

[commit-bot: I haz the power, 2012-04-23 17:52:56]

Presubmit check for 10165020-11002 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/printing/cloud_print

Presubmit checks took 2.6s to calculate.

[simonhong_, 2012-04-23 19:49:36]

On 2012/04/23 17:52:56, I haz the power (commit-bot) wrote:
> Presubmit check for 10165020-11002 failed and returned exit status 1.
> 
> Running presubmit commit checks ...
> 
> ** Presubmit ERRORS **
> Missing LGTM from an OWNER for files in these directories:
>     chrome/browser/printing/cloud_print
> 
> Presubmit checks took 2.6s to calculate.

Dear Lei (thestig),
Please review below directory.
  chrome/browser/printing/cloud_print/*
Thank you.

[Lei Zhang, 2012-04-23 19:56:49]

lgtm

[commit-bot: I haz the power, 2012-04-23 20:02:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/simon.hong81@gmail.com/10165020/11002

[commit-bot: I haz the power, 2012-04-23 20:21:57]

Try job failure for 10165020-11002 (retry) on mac_rel for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[simonhong_, 2012-04-23 21:10:22]

On 2012/04/23 20:21:57, I haz the power (commit-bot) wrote:
> Try job failure for 10165020-11002 (retry) on mac_rel for step "compile"
> (clobber build).
> It's a second try, previously, step "compile" failed.
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

Dear brettw,
I modified below three files.
Please check.
  chrome/browser/ui/webui/ntp/favicon_webui_handler.cc
  chrome/browser/ui/webui/chrome_web_ui_data_source.cc
  chrome/browser/ui/webui/conflicts_ui.cc
Thank you.

[Lei Zhang, 2012-04-23 21:21:12]

Patch set 3 LGTM.

[commit-bot: I haz the power, 2012-04-23 21:54:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/simon.hong81@gmail.com/10165020/25002

[commit-bot: I haz the power, 2012-04-23 22:15:21]

Try job failure for 10165020-25002 (retry) on linux_chromeos for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[simonhong_, 2012-04-24 13:43:50]

On 2012/04/23 22:15:21, I haz the power (commit-bot) wrote:
> Try job failure for 10165020-25002 (retry) on linux_chromeos for step
"compile"
> (clobber build).
> It's a second try, previously, step "compile" failed.
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

Why static_cast cannot convert base::RefCountedStaticMemory to RefCountedMemory?
It is strange that compiler suggest to use reinterpret_cast instead of
static_cast.
RefCountedMemory is base class of RefCountedStaticMemory...

[simonhong_, 2012-04-24 13:51:43]

On 2012/04/24 13:43:50, Simon Hong wrote:
> On 2012/04/23 22:15:21, I haz the power (commit-bot) wrote:
> > Try job failure for 10165020-25002 (retry) on linux_chromeos for step
> "compile"
> > (clobber build).
> > It's a second try, previously, step "compile" failed.
> >
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...
> 
> Why static_cast cannot convert base::RefCountedStaticMemory to
RefCountedMemory?
> It is strange that compiler suggest to use reinterpret_cast instead of
> static_cast.
> RefCountedMemory is base class of RefCountedStaticMemory...

Oops, I didn't include header file.

[commit-bot: I haz the power, 2012-04-24 14:02:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/simon.hong81@gmail.com/10165020/44001

[commit-bot: I haz the power, 2012-04-24 14:25:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/simon.hong81@gmail.com/10165020/45035

[commit-bot: I haz the power, 2012-04-24 16:18:38]

Change committed as 133702