Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 10165017: [Chrome OS ECHO]: Move to manifest version 2, and enable CSP (Closed)

Created:
8 years, 8 months ago by gauravsh
Modified:
8 years, 8 months ago
CC:
chromium-reviews, arv (Not doing code reviews), nkostylev+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

[Chrome OS ECHO]: Move to manifest version 2, and enable CSP BUG=chromium-os:28353 TEST=Verify google api is correctly loaded Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133533

Patch Set 1 #

Total comments: 2

Patch Set 2 : rm #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/browser/resources/chromeos/echo/manifest.json View 1 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
gauravsh
8 years, 8 months ago (2012-04-20 22:10:05 UTC) #1
Jorge Lucangeli Obes
http://codereview.chromium.org/10165017/diff/1/chrome/browser/resources/chromeos/echo/manifest.json File chrome/browser/resources/chromeos/echo/manifest.json (right): http://codereview.chromium.org/10165017/diff/1/chrome/browser/resources/chromeos/echo/manifest.json#newcode10 chrome/browser/resources/chromeos/echo/manifest.json:10: "content_security_policy": "default-src 'self'; script-src 'self' https://apis.google.com; frame-src 'self' https://www.googleapis.com ...
8 years, 8 months ago (2012-04-20 22:15:03 UTC) #2
gauravsh
http://codereview.chromium.org/10165017/diff/1/chrome/browser/resources/chromeos/echo/manifest.json File chrome/browser/resources/chromeos/echo/manifest.json (right): http://codereview.chromium.org/10165017/diff/1/chrome/browser/resources/chromeos/echo/manifest.json#newcode10 chrome/browser/resources/chromeos/echo/manifest.json:10: "content_security_policy": "default-src 'self'; script-src 'self' https://apis.google.com; frame-src 'self' https://www.googleapis.com ...
8 years, 8 months ago (2012-04-20 22:19:13 UTC) #3
Jorge Lucangeli Obes
lgtm
8 years, 8 months ago (2012-04-20 22:23:23 UTC) #4
gauravsh
Need full commiter/owner stamp.
8 years, 8 months ago (2012-04-20 23:12:34 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 8 months ago (2012-04-20 23:16:22 UTC) #6
xiyuan
lgtm
8 years, 8 months ago (2012-04-23 20:23:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gauravsh@chromium.org/10165017/5001
8 years, 8 months ago (2012-04-23 20:25:37 UTC) #8
commit-bot: I haz the power
8 years, 8 months ago (2012-04-23 22:10:20 UTC) #9
Change committed as 133533

Powered by Google App Engine
This is Rietveld 408576698