Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 10165016: Add audio buffer size notification to NaCl proxy.... (Closed)

Created:
8 years, 8 months ago by nfullagar
Modified:
8 years, 8 months ago
Reviewers:
brettw, enal1
CC:
chromium-reviews
Visibility:
Public.

Description

Add audio buffer size notification to NaCl proxy. BUG=http://code.google.com/p/chromium/issues/detail?id=120837 TEST=variuos nacl audio samples Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133502

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -6 lines) Patch
M ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_audio.cc View 1 2 3 4 4 chunks +30 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
nfullagar
8 years, 8 months ago (2012-04-20 21:45:22 UTC) #1
enal1
lgtm with nits. http://codereview.chromium.org/10165016/diff/2001/ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_audio.cc File ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_audio.cc (right): http://codereview.chromium.org/10165016/diff/2001/ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_audio.cc#newcode43 ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_audio.cc:43: char* end = static_cast<char*>(audio_buffer) + buffer_size_in_bytes; ...
8 years, 8 months ago (2012-04-20 21:56:27 UTC) #2
nfullagar
done, done. thx.
8 years, 8 months ago (2012-04-20 22:21:44 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 8 months ago (2012-04-20 22:51:36 UTC) #4
brettw
LGTM rubberstamp
8 years, 8 months ago (2012-04-23 17:40:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nfullagar@google.com/10165016/4002
8 years, 8 months ago (2012-04-23 17:57:27 UTC) #6
commit-bot: I haz the power
Presubmit check for 10165016-4002 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 8 months ago (2012-04-23 17:57:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nfullagar@google.com/10165016/13001
8 years, 8 months ago (2012-04-23 18:19:59 UTC) #8
commit-bot: I haz the power
8 years, 8 months ago (2012-04-23 19:50:52 UTC) #9
Change committed as 133502

Powered by Google App Engine
This is Rietveld 408576698