Correct process id for sandbox'd trace events.

Correct process id for sandbox'd trace events.

Trace events collected from suid sandbox'd threads need to report
their real pid and not the sandbox'd pid so data can be correlated
with system event data.

BUG=chromium-os:27809
TEST=check sandbox'd trace data against the output of ps

Change-Id: Ia8c7725ac6e4f18a2114de027a5d19ba15f49e60


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133619

[Markus (顧孟勤), 2012-04-20 21:13:29]

lgtm

http://codereview.chromium.org/10165015/diff/1/content/browser/zygote_main_li...
File content/browser/zygote_main_linux.cc (right):

http://codereview.chromium.org/10165015/diff/1/content/browser/zygote_main_li...
content/browser/zygote_main_linux.cc:334: static_cast<int>(real_pid));
You mentioned that this is currently something that is only need for CrOS. Just
double-checking that you verified the code is harmless on non-CrOS builds for
OS_LINUX.

Other than that, this change looks fine to me. Glad to see that it is a
relatively simple and well-contained change. Of course, computing thread ids is
going to be a little more challenging.

[Jorge Lucangeli Obes, 2012-04-20 21:38:47]

lgtm

[commit-bot: I haz the power, 2012-04-23 19:36:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sleffler@chromium.org/10165015/1

[commit-bot: I haz the power, 2012-04-23 19:36:26]

Presubmit check for 10165015-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    content/browser

Presubmit checks took 1.4s to calculate.

[Sam Leffler, 2012-04-23 19:39:03]

Add Will for OWNER review.

[willchan no longer on Chromium, 2012-04-23 20:05:22]

Not in OWNERS there.

On Mon, Apr 23, 2012 at 12:39 PM, <sleffler@chromium.org> wrote:

> Add Will for OWNER review.
>
>
http://codereview.chromium.**org/10165015/<http://codereview.chromium.org/101...
>

[Sam Leffler, 2012-04-23 20:20:53]

try again for an owner

[Chris Evans, 2012-04-23 23:23:33]

On 2012/04/23 20:20:53, Sam Leffler wrote:
> try again for an owner

lgtm

[commit-bot: I haz the power, 2012-04-23 23:34:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sleffler@chromium.org/10165015/1

[commit-bot: I haz the power, 2012-04-24 03:04:55]

Change committed as 133619