webkit/media/webmediaplayer_impl.h - Issue 10164017: Implement sourceAddId() & sourceRemoveId()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/media/webmediaplayer_impl.h

Issue 10164017: Implement sourceAddId() & sourceRemoveId() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address CR comments Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webkit/media/webmediaplayer_impl.h

diff --git a/webkit/media/webmediaplayer_impl.h b/webkit/media/webmediaplayer_impl.h

index ae1e889ec00fc5dc3df2754cb59d6d2124219db0..83c2c0dafc50010e3e1e8d30dc25b1237e129804 100644

--- a/webkit/media/webmediaplayer_impl.h

+++ b/webkit/media/webmediaplayer_impl.h

@@ -181,7 +181,14 @@ class WebMediaPlayerImpl

virtual WebKit::WebAudioSourceProvider* audioSourceProvider();

+ virtual AddIdStatus sourceAddId(const WebKit::WebString& id,

+ const WebKit::WebString& type);

+ virtual bool sourceRemoveId(const WebKit::WebString& id);

+ // TODO(acolwell): Remove non-id version when http://webk.it/83788 fix lands.

virtual bool sourceAppend(const unsigned char* data, unsigned length);

+ virtual bool sourceAppend(const WebKit::WebString& id,

+ const unsigned char* data,

+ unsigned length);

virtual void sourceEndOfStream(EndOfStreamStatus status);

virtual MediaKeyException generateKeyRequest(

« no previous file with comments | « media/filters/pipeline_integration_test.cc ('k') | webkit/media/webmediaplayer_impl.cc » ('j') | no next file with comments »