Move the FlashClipboard API into the Flash one.

Move the FlashClipboard API into the Flash one.

This allows us to delete the separate proxy files for this.

BUG=
TEST=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133955

[brettw, 2012-04-20 22:25:06]

Not super high priority. This is just cleanup to save some code (184 net lines
lost).

[brettw, 2012-04-20 22:26:01]

This depends on this patch https://chromiumcodereview.appspot.com/10091003/
which hasn't landed yet. That patch changes the way Flash is routed to allow
this type of cleanup.

[raymes, 2012-04-23 03:18:10]

https://chromiumcodereview.appspot.com/10163012/diff/1/ppapi/proxy/ppb_flash_...
File ppapi/proxy/ppb_flash_proxy.cc (right):

https://chromiumcodereview.appspot.com/10163012/diff/1/ppapi/proxy/ppb_flash_...
ppapi/proxy/ppb_flash_proxy.cc:326: result.Return(dispatcher(),
PP_MakeUndefined());
I assume we should have been setting return values for these error cases all
along.

https://chromiumcodereview.appspot.com/10163012/diff/1/ppapi/thunk/interfaces...
File ppapi/thunk/interfaces_ppb_private_flash.h (right):

https://chromiumcodereview.appspot.com/10163012/diff/1/ppapi/thunk/interfaces...
ppapi/thunk/interfaces_ppb_private_flash.h:25: PROXIED_IFACE(PPB_Flash,
I'm unsure of why this needs to be added. Is this to support the (now) legacy
interfaces)? Should this have been there in the first place?

[brettw, 2012-04-24 19:48:29]

New snap up. Due to a failed test I added back in some error checking. I added
this in a new ppb_flash_shared file. The error checking isn't used in the _impl
side right now, but I think we may want to add this in the future. And we'll
want to use the _shared file for some other stuff in the future, so it's nice to
add anyway.

https://chromiumcodereview.appspot.com/10163012/diff/1/ppapi/proxy/ppb_flash_...
File ppapi/proxy/ppb_flash_proxy.cc (right):

https://chromiumcodereview.appspot.com/10163012/diff/1/ppapi/proxy/ppb_flash_...
ppapi/proxy/ppb_flash_proxy.cc:326: result.Return(dispatcher(),
PP_MakeUndefined());
It was always set before. Now that there is a way to fail earlier before
actually doing the call, we need to add this.

https://chromiumcodereview.appspot.com/10163012/diff/1/ppapi/thunk/interfaces...
File ppapi/thunk/interfaces_ppb_private_flash.h (right):

https://chromiumcodereview.appspot.com/10163012/diff/1/ppapi/thunk/interfaces...
ppapi/thunk/interfaces_ppb_private_flash.h:25: PROXIED_IFACE(PPB_Flash,
The point of this is that I removed the manual registration in interface_list.cc
and plugin_module.cc so we can now use these macros which make adding versions
easier. When I wrote this I realized I forgot to remove the code in
plugin_module, so the latest patch fixes that.

[raymes, 2012-04-25 17:33:42]

lgtm