Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 10162028: Check RendererAccessibility mode instead of WebKit accessibilityEnabled. (Closed)

Created:
8 years, 8 months ago by dmazzoni
Modified:
8 years, 8 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, aboxhall, aaronlevbugs
Visibility:
Public.

Description

Check RendererAccessibility mode instead of WebKit accessibilityEnabled. We were hitting an assertion failure that indicated that WebKit accessibility was enabled, but RendererAccessibility's mode was that accessibility is off. Note that WebKit accessibility is a global flag, once enabled, it is never turned off. This could happen if a new RenderViewImpl is created in the same process where WebKit accessibility was previously enabled, but the newly-created RendererAccessibility mode is off. The fix is to never call handle accessibility notifications if RendererAccessibility's mode is off, regardless of WebKit's accessibility notification flag. BUG=123649 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133489

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -8 lines) Patch
M content/renderer/renderer_accessibility.cc View 9 chunks +11 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dmazzoni
dtseng: primary review avi: OWNERS review for content/
8 years, 8 months ago (2012-04-23 08:23:29 UTC) #1
Avi (use Gerrit)
owner LGTM
8 years, 8 months ago (2012-04-23 14:48:27 UTC) #2
David Tseng
lgtm
8 years, 8 months ago (2012-04-23 16:32:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/10162028/1
8 years, 8 months ago (2012-04-23 16:48:43 UTC) #4
commit-bot: I haz the power
8 years, 8 months ago (2012-04-23 18:59:33 UTC) #5
Change committed as 133489

Powered by Google App Engine
This is Rietveld 408576698