Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(937)

Issue 10162027: Reimplement CrosProposeScan without Libcros (Closed)

Created:
8 years, 8 months ago by hashimoto
Modified:
8 years, 8 months ago
Reviewers:
stevenjb
CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Reimplement CrosProposeScan without Libcros BUG=chromium-os:16557 TEST=unit_test --gtest_filter="CrosNetworkFunctions*" Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133632

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -1 line) Patch
M chrome/browser/chromeos/cros/cros_network_functions.cc View 1 1 chunk +6 lines, -1 line 0 comments Download
M chrome/browser/chromeos/cros/cros_network_functions_unittest.cc View 1 2 chunks +14 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/cros/mock_chromeos_network.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/cros/mock_chromeos_network.cc View 1 3 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
hashimoto
8 years, 8 months ago (2012-04-23 07:30:13 UTC) #1
stevenjb
lgtm
8 years, 8 months ago (2012-04-23 21:42:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/10162027/1
8 years, 8 months ago (2012-04-24 02:29:00 UTC) #3
commit-bot: I haz the power
8 years, 8 months ago (2012-04-24 04:56:03 UTC) #4
Change committed as 133632

Powered by Google App Engine
This is Rietveld 408576698