Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10162015: Pull domstorage specifics out of RenderThreadImpl into DomStorageDispatcher (Closed)

Created:
8 years, 8 months ago by michaeln
Modified:
8 years, 7 months ago
Reviewers:
ericu, jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jsbell
Visibility:
Public.

Description

Pull domstorage specifics out of RenderThreadImpl into a seperate DomStorageDispatcher class, and move existing renderer side domstorage sources into a subdirectory so OWNERS can be applied more meaningfully. BUG=94382 TBR=jam Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=136188

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Total comments: 1

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -323 lines) Patch
M content/content_renderer.gypi View 1 2 3 4 5 6 2 chunks +6 lines, -4 lines 0 comments Download
A content/renderer/dom_storage/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
A content/renderer/dom_storage/dom_storage_dispatcher.h View 1 2 3 4 5 6 1 chunk +29 lines, -0 lines 0 comments Download
A content/renderer/dom_storage/dom_storage_dispatcher.cc View 1 2 3 4 5 6 1 chunk +58 lines, -0 lines 0 comments Download
A + content/renderer/dom_storage/webstoragearea_impl.h View 1 2 3 4 5 6 2 chunks +10 lines, -9 lines 0 comments Download
A + content/renderer/dom_storage/webstoragearea_impl.cc View 1 2 5 chunks +13 lines, -15 lines 0 comments Download
A + content/renderer/dom_storage/webstoragenamespace_impl.h View 1 2 3 4 5 6 1 chunk +8 lines, -9 lines 0 comments Download
A + content/renderer/dom_storage/webstoragenamespace_impl.cc View 1 2 3 4 5 6 2 chunks +14 lines, -12 lines 0 comments Download
M content/renderer/render_thread_impl.h View 1 2 3 4 5 6 3 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 2 3 4 5 6 8 chunks +7 lines, -44 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 4 5 6 4 chunks +2 lines, -3 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 1 2 3 4 5 6 3 chunks +2 lines, -2 lines 0 comments Download
D content/renderer/renderer_webstoragearea_impl.h View 1 2 3 4 5 6 1 chunk +0 lines, -38 lines 0 comments Download
D content/renderer/renderer_webstoragearea_impl.cc View 1 2 3 4 5 6 1 chunk +0 lines, -108 lines 0 comments Download
D content/renderer/renderer_webstoragenamespace_impl.h View 1 2 3 4 5 6 1 chunk +0 lines, -31 lines 0 comments Download
D content/renderer/renderer_webstoragenamespace_impl.cc View 1 2 3 4 5 6 1 chunk +0 lines, -46 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
michaeln
Just shuffling files around in this CL, no real changes. Doing this in advance of ...
8 years, 7 months ago (2012-05-08 17:57:24 UTC) #1
ericu
LGTM http://codereview.chromium.org/10162015/diff/19005/content/renderer/dom_storage/webstoragearea_impl.h File content/renderer/dom_storage/webstoragearea_impl.h (right): http://codereview.chromium.org/10162015/diff/19005/content/renderer/dom_storage/webstoragearea_impl.h#newcode1 content/renderer/dom_storage/webstoragearea_impl.h:1: // Copyright (c) 2011 The Chromium Authors. All ...
8 years, 7 months ago (2012-05-09 21:28:46 UTC) #2
michaeln
8 years, 7 months ago (2012-05-09 22:27:05 UTC) #3 
> Update copyright dates.

Done

Powered by Google App Engine
This is Rietveld 408576698