Allow serialization of ArrayBuffer params in extension/apps API methods

chrome/renderer/resources/extensions/send_request.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var chromeHidden = requireNative('chrome_hidden').GetChromeHidden();
 var natives = requireNative('sendRequest');
 
 // Callback handling.
 var requests = [];
 chromeHidden.handleResponse = function(requestId, name,
@@ skipping 89 matching lines @@
   if (!opt_args)
     opt_args = {};
   var request = prepareRequest(args, argSchemas);
   if (opt_args.customCallback) {
     request.customCallback = opt_args.customCallback;
   }
   // JSON.stringify doesn't support a root object which is undefined.
   if (request.args === undefined)
     request.args = null;
 
-  var sargs = opt_args.noStringify ?
-      request.args : chromeHidden.JSON.stringify(request.args);
+  // TODO(asargent) - convert all optional native functions to accept raw
+  // v8 values instead of expecting JSON strings.
+  var doStringify = false;
+  if (opt_args.nativeFunction && !opt_args.noStringify)

[asargent_no_longer_on_chrome, 2012/05/04 22:42:22]

FYI, this line fixes browser test failures I was getting from patch set 3
because I was forgetting to test the "noStringify" option in the case where an
API method has its own nativeFunction. It turns out the setIcon methods do this.

+    doStringify = true;
+  var requestArgs = doStringify ?
+      chromeHidden.JSON.stringify(request.args) : request.args;
   var nativeFunction = opt_args.nativeFunction || natives.StartRequest;
 
   var requestId = natives.GetNextRequestId();
   request.id = requestId;
   requests[requestId] = request;
   var hasCallback =
       (request.callback || opt_args.customCallback) ? true : false;
-  return nativeFunction(functionName, sargs, requestId, hasCallback,
+  return nativeFunction(functionName, requestArgs, requestId, hasCallback,
                         opt_args.forIOThread);
 }
 
 exports.sendRequest = sendRequest;