Add PathUtilsTest.

Add PathUtilsTest.

 - This test invokes JNI calls and included only if gtest_target_type=shared_library.
 - Also set the application context to get these JNI calls working.

BUG=125059
TEST=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134144

[John Grabowski, 2012-04-25 20:22:12]

http://codereview.chromium.org/10161032/diff/1/base/android/path_utils_unitte...
File base/android/path_utils_unittest.cc (right):

http://codereview.chromium.org/10161032/diff/1/base/android/path_utils_unitte...
base/android/path_utils_unittest.cc:1: // Copyright (c) 2011 The Chromium
Authors. All rights reserved.
2012

http://codereview.chromium.org/10161032/diff/1/base/android/path_utils_unitte...
base/android/path_utils_unittest.cc:15: TEST_F(PathUtilsTest,
TestGetDataDirectory) {
Add comments to explain hard-coding.
E.g. "this path comes from Android system blah blah"

http://codereview.chromium.org/10161032/diff/1/testing/android/native_test_la...
File testing/android/native_test_launcher.cc (right):

http://codereview.chromium.org/10161032/diff/1/testing/android/native_test_la...
testing/android/native_test_launcher.cc:183:
base::android::ScopedJavaLocalRef<jobject> scoped_context(env, app_context);
This doesn't look correct.  You don't create the localRef so you shouldn't
release it with the dtor of an object like this.  
If you NewLocalRef, then it is safe to delete.

[Yaron, 2012-04-25 20:32:36]

lgtm once jrg's comment is resolved

Since we'll have many patches around this effort, you should probably file a
tracking bug for java unit test bring-up

http://codereview.chromium.org/10161032/diff/1/base/android/path_utils_unitte...
File base/android/path_utils_unittest.cc (right):

http://codereview.chromium.org/10161032/diff/1/base/android/path_utils_unitte...
base/android/path_utils_unittest.cc:12: class PathUtilsTest : public
testing::Test {
Seen this more commonly as:
typedef testing::Test PathUtilsTest;

[nilesh, 2012-04-25 23:33:26]

Added a bug.

http://codereview.chromium.org/10161032/diff/1/base/android/path_utils_unitte...
File base/android/path_utils_unittest.cc (right):

http://codereview.chromium.org/10161032/diff/1/base/android/path_utils_unitte...
base/android/path_utils_unittest.cc:1: // Copyright (c) 2011 The Chromium
Authors. All rights reserved.
On 2012/04/25 20:22:12, John Grabowski wrote:
> 2012

Done.

http://codereview.chromium.org/10161032/diff/1/base/android/path_utils_unitte...
base/android/path_utils_unittest.cc:12: class PathUtilsTest : public
testing::Test {
On 2012/04/25 20:32:37, Yaron wrote:
> Seen this more commonly as:
> typedef testing::Test PathUtilsTest;

Done.

http://codereview.chromium.org/10161032/diff/1/base/android/path_utils_unitte...
base/android/path_utils_unittest.cc:15: TEST_F(PathUtilsTest,
TestGetDataDirectory) {
On 2012/04/25 20:22:12, John Grabowski wrote:
> Add comments to explain hard-coding.
> E.g. "this path comes from Android system blah blah"

Done.

http://codereview.chromium.org/10161032/diff/1/testing/android/native_test_la...
File testing/android/native_test_launcher.cc (right):

http://codereview.chromium.org/10161032/diff/1/testing/android/native_test_la...
testing/android/native_test_launcher.cc:183:
base::android::ScopedJavaLocalRef<jobject> scoped_context(env, app_context);
On 2012/04/25 20:22:12, John Grabowski wrote:
> This doesn't look correct.  You don't create the localRef so you shouldn't
> release it with the dtor of an object like this.  
> If you NewLocalRef, then it is safe to delete.

Thanks for explaining this. I am now creating a NewLocalRef and packing it into
a ScopedJavaLocalRef

[John Grabowski, 2012-04-26 00:17:36]

LGTM!

[John Grabowski, 2012-04-26 00:18:19]

+mark base/ OWNERS

[Mark Mentovai, 2012-04-26 15:54:59]

LGTM

[commit-bot: I haz the power, 2012-04-26 17:58:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/10161032/9003

[commit-bot: I haz the power, 2012-04-26 20:19:54]

Change committed as 134144