Issue 10161009: Use new WebElement attribute accessors so we can delete WebNamedNodeMap.

Issue 10161009: Use new WebElement attribute accessors so we can delete WebNamedNodeMap. (Closed)

Created:
8 years, 8 months ago by dmazzoni

Modified:
8 years, 8 months ago

Reviewers:
awesomekling, jamesr

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Use new WebElement attribute accessors so we can delete WebNamedNodeMap. BUG=123094 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133299

Patch Set 2 : Delete include of WebAttribute too #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -5 lines)			Patch
	M	webkit/glue/webaccessibility.cc	View	1	2 chunks	+3 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

jamesr

lgtm http://codereview.chromium.org/10161009/diff/1/webkit/glue/webaccessibility.cc File webkit/glue/webaccessibility.cc (right): http://codereview.chromium.org/10161009/diff/1/webkit/glue/webaccessibility.cc#newcode14 webkit/glue/webaccessibility.cc:14: #include "third_party/WebKit/Source/WebKit/chromium/public/WebAttribute.h" delete this #include too if it's ...

8 years, 8 months ago (2012-04-20 21:06:33 UTC) #2

dmazzoni

http://codereview.chromium.org/10161009/diff/1/webkit/glue/webaccessibility.cc File webkit/glue/webaccessibility.cc (right): http://codereview.chromium.org/10161009/diff/1/webkit/glue/webaccessibility.cc#newcode14 webkit/glue/webaccessibility.cc:14: #include "third_party/WebKit/Source/WebKit/chromium/public/WebAttribute.h" On 2012/04/20 21:06:33, jamesr wrote: > delete ...

8 years, 8 months ago (2012-04-20 21:10:22 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/10161009/5001

8 years, 8 months ago (2012-04-20 21:10:45 UTC) #4

Change committed as 133299

Expand Messages | Collapse Messages