src/utils.h - Issue 1016006: Reenable ability to Dispose already Disposed Vector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Chromium Code Reviews

Unified Diff: src/utils.h

Issue 1016006: Reenable ability to Dispose already Disposed Vector. (Closed)

Patch Set: Created 10 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/utils.h

diff --git a/src/utils.h b/src/utils.h

index 4a9d871ce8646068497a49095f1bc5da003d92c6..89cc5ef4a5587e6bece7093a2734379e4714fea5 100644

--- a/src/utils.h

+++ b/src/utils.h

@@ -342,7 +342,6 @@ class Vector {

// vector is empty.

void Dispose() {

DeleteArray(start_);

- if (is_empty()) return;

start_ = NULL;

length_ = 0;

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »