Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(981)

Unified Diff: chrome/installer/setup/install.h

Issue 10160011: Create VisualElementsManifest.xml from template -- install VisualElements in the version directory (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: typo typi typa Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/setup/install.h
diff --git a/chrome/installer/setup/install.h b/chrome/installer/setup/install.h
index 370c51e46053630e40da6a52718d530d760139e7..05120e3f6c68ce49ebe94cff871808865bd72a97 100644
--- a/chrome/installer/setup/install.h
+++ b/chrome/installer/setup/install.h
@@ -1,4 +1,4 @@
-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
//
@@ -23,6 +23,17 @@ class InstallationState;
class InstallerState;
class MasterPreferences;
+// Escape the display name as per the XML AttValue production
grt (UTC plus 2) 2012/05/05 02:16:59 sorry i missed this before: please replace "the di
gab 2012/05/05 16:19:51 Done.
+// (http://www.w3.org/TR/2008/REC-xml-20081126/#NT-AttValue) for a value in
+// single quotes.
+void EscapeXmlAttributeValueInSingleQuotes(string16* att_value);
+
+// Creates VisualElementsManifest.xml beside chrome.exe in |src_path| if
+// |src_path|\VisualElements exists.
+// Returns true unless the manifest is supposed to be created, but fails to be.
+bool CreateVisualElementsManifest(const FilePath& src_path,
+ const Version& version);
+
// This function installs or updates a new version of Chrome. It returns
// install status (failed, new_install, updated etc).
//

Powered by Google App Engine
This is Rietveld 408576698