chrome/installer/util/util_constants.h - Issue 10160011: Create VisualElementsManifest.xml from template -- install VisualElements in the version directory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/util/util_constants.h

Issue 10160011: Create VisualElementsManifest.xml from template -- install VisualElements in the version directory (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: refactored the new code --> template logic in install_util.cc Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/installer/util/util_constants.h

diff --git a/chrome/installer/util/util_constants.h b/chrome/installer/util/util_constants.h

index fc8f7b2b1e73165ef87c7d1717d447d0d38b9cd6..be87b4cc7994f895e4baa27312cdc75cca580b6d 100644

--- a/chrome/installer/util/util_constants.h

+++ b/chrome/installer/util/util_constants.h

@@ -113,12 +113,13 @@ enum InstallerStage {

REMOVING_OLD_VERSIONS, // 14: Deleting old version directories.

FINISHING, // 15: Finishing the install.

CONFIGURE_AUTO_LAUNCH, // 16: Configuring Chrome to auto-launch.

- NUM_STAGES // 17: The number of stages.

+ CREATING_VISUAL_MANIFEST, // 17: Create VisualElementsManifest.xml

grt (UTC plus 2) 2012/05/03 17:49:37 Create -> Creating

+ NUM_STAGES // 18: The number of stages.

};

// When we start reporting the numerical values from the enum, the order

// above MUST be preserved.

-COMPILE_ASSERT(CONFIGURE_AUTO_LAUNCH == 16,

+COMPILE_ASSERT(CREATING_VISUAL_MANIFEST == 17,

never_ever_ever_change_InstallerStage_values_bang);

namespace switches {

« chrome/installer/util/install_util.cc ('K') | « chrome/installer/util/install_util.cc ('k') | chrome/tools/build/win/create_installer_archive.py » ('j') | no next file with comments »