Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10159)

Unified Diff: chrome/installer/mini_installer/chrome.release

Issue 10160011: Create VisualElementsManifest.xml from template -- install VisualElements in the version directory (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: refactored the new code --> template logic in install_util.cc Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/installer/setup/install.cc » ('j') | chrome/installer/setup/install.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/mini_installer/chrome.release
diff --git a/chrome/installer/mini_installer/chrome.release b/chrome/installer/mini_installer/chrome.release
index 79ea14641f94c61a9ee73ca12aea8224381df8df..30581c687e123d712c79f408c731328653cb921e 100644
--- a/chrome/installer/mini_installer/chrome.release
+++ b/chrome/installer/mini_installer/chrome.release
@@ -5,7 +5,6 @@
[GENERAL]
chrome.exe: %(ChromeDir)s\
wow_helper.exe: %(ChromeDir)s\
-Dictionaries\en-US.bdic: %(ChromeDir)s\Dictionaries
chrome.dll: %(VersionDir)s\
nacl64.exe: %(VersionDir)s\
ppGoogleNaClPluginChrome.dll: %(VersionDir)s\
@@ -40,10 +39,6 @@ ui_resources_2x.pak: %(VersionDir)s\
theme_resources_touch_1x.pak: %(VersionDir)s\
[GOOGLE_CHROME]
-splash-620x300.png: %(ChromeDir)s\
-Logo.png: %(ChromeDir)s\
-SmallLogo.png: %(ChromeDir)s\
-VisualElementsManifest.xml: %(ChromeDir)s\
delegate_execute.exe: %(VersionDir)s\
gcswf32.dll: %(VersionDir)s\
metro_driver.dll: %(VersionDir)s\
@@ -52,3 +47,10 @@ FlashPlayerApp.exe: %(VersionDir)s\
FlashPlayerCPLApp.cpl: %(VersionDir)s\
PepperFlash\pepflashplayer.dll: %(VersionDir)s\PepperFlash\
PepperFlash\manifest.json: %(VersionDir)s\PepperFlash\
+# All or none of the following 3 files need to be present as the creation of
+# VisualElementsManifest.xml is based on the existence of
+# %(VersionDir)\VisualElements. On a similar note, no other files should be
+# packaged in this directory.
+splash-620x300.png: %(VersionDir)s\VisualElements
grt (UTC plus 2) 2012/05/03 17:49:37 nit: all other entries have a trailing '\'. pleas
gab 2012/05/03 19:03:48 Done.
+Logo.png: %(VersionDir)s\VisualElements
+SmallLogo.png: %(VersionDir)s\VisualElements
« no previous file with comments | « no previous file | chrome/installer/setup/install.cc » ('j') | chrome/installer/setup/install.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698