Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10160006: more s/localStrings/loadTimeData (Closed)

Created:
8 years, 8 months ago by Evan Stade
Modified:
8 years, 7 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, Aaron Boodman, arv (Not doing code reviews), mihaip+watch_chromium.org
Visibility:
Public.

Description

more s/localStrings/loadTimeData BUG=122753 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134572

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/browser/resources/extensions/pack_extension_overlay.js View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Evan Stade
8 years, 8 months ago (2012-04-26 22:44:28 UTC) #1
Dan Beam
lgtm, though I don't see where you're including load_time_data.js
8 years, 7 months ago (2012-04-30 17:05:22 UTC) #2
Dan Beam
nvm, http://code.google.com/searchframe#OAMlx_jo-ck/src/chrome/browser/resources/extensions/extensions.html&l=16
8 years, 7 months ago (2012-04-30 17:14:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/10160006/1
8 years, 7 months ago (2012-04-30 18:07:15 UTC) #4
commit-bot: I haz the power
8 years, 7 months ago (2012-04-30 19:52:27 UTC) #5 
Change committed as 134572

Powered by Google App Engine
This is Rietveld 408576698