Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 10155030: Fix button order to OK, Cancel (Closed)

Created:
8 years, 8 months ago by SeRya
Modified:
8 years, 8 months ago
CC:
chromium-reviews, Aaron Boodman, arv (Not doing code reviews), nkostylev+watch_chromium.org, mihaip+watch_chromium.org, Evan Stade, Lei Zhang
Visibility:
Public.

Description

Fix button order to OK, Cancel BUG=chromium-os:29684 TEST=Manual test. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133864

Patch Set 1 #

Total comments: 2

Messages

Total messages: 8 (0 generated)
SeRya
8 years, 8 months ago (2012-04-24 16:22:43 UTC) #1
James Hawkins
To be clear, the expected order for CrOS is "OK/Cancel", correct?
8 years, 8 months ago (2012-04-24 16:25:08 UTC) #2
SeRya
On 2012/04/24 16:25:08, James Hawkins wrote: > To be clear, the expected order for CrOS ...
8 years, 8 months ago (2012-04-24 20:19:52 UTC) #3
James Hawkins
lgtm
8 years, 8 months ago (2012-04-24 20:35:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/serya@chromium.org/10155030/1
8 years, 8 months ago (2012-04-25 02:38:09 UTC) #5
commit-bot: I haz the power
Change committed as 133864
8 years, 8 months ago (2012-04-25 05:03:29 UTC) #6
Lei Zhang
Umm, in several cases, like with print preview, this flipped it for all platforms. On ...
8 years, 8 months ago (2012-04-26 22:31:08 UTC) #7
Evan Stade
8 years, 8 months ago (2012-04-26 22:51:08 UTC) #8
I think print preview is the only one that is wrong. The changes to the pack
extension overlay and alert overlay were correct, and the rest are chromeos
only.

http://codereview.chromium.org/10155030/diff/1/chrome/browser/resources/exten...
File chrome/browser/resources/extensions/pack_extension_overlay.html (right):

http://codereview.chromium.org/10155030/diff/1/chrome/browser/resources/exten...
chrome/browser/resources/extensions/pack_extension_overlay.html:23: <button
id="packExtensionDismiss" i18n-content="cancel"></button>
this is correct

http://codereview.chromium.org/10155030/diff/1/chrome/browser/resources/print...
File chrome/browser/resources/print_preview/print_preview.html (right):

http://codereview.chromium.org/10155030/diff/1/chrome/browser/resources/print...
chrome/browser/resources/print_preview/print_preview.html:28: <button
id="cancel-button" i18n-content="cancelButton"></button>
this is wrong --- if the css rule in print_preview.css is not working as
expected, it should be fixed.

Powered by Google App Engine
This is Rietveld 408576698