Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 10155015: Process all global shortcuts for Ash after InputMethodEventFilter (Closed)

Created:
8 years, 8 months ago by Yusuke Sato
Modified:
8 years, 8 months ago
CC:
chromium-reviews, mazda+watch_chromium.org, sadrul, derat+watch_chromium.org, ben+watch_chromium.org
Visibility:
Public.

Description

Process all global shortcuts for Ash after InputMethodEventFilter. This CL is for crbug.com/123856 (Aura shell applies accelerators without giving apps the option of handling key events). Currently, shortcuts for IME/layout switching (Shift+Alt, Ctrl+space, and so on) are processed before InputMethodEventFilter, and other Ash global shortcuts are processed after the filter. This is for ensuring that the IME shortcuts always work even if an IME (or an IME extension - http://dev.chromium.org/developers/design-documents/extensions/proposed-changes/apis-under-development/input-method-editor) tries to consume the shortcuts. However, this strategy is not compatible with crbug.com/123856. In order to fix crbug.com/123856, we sometimes have to process an Ash global shortcut key (including IME ones) after the key is passed to a web page. This CL modifies accelerator_table.cc and shell.cc so that they process IME shortcuts after InputMethodEventFilter, and also simplifies ash/accelerators/ and ui/base/accelerators/accelerator_manager.cc by removing code for processing pre-IME shortcuts. BUG=123856 TEST=ran aura_shell_unittests and ui_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133642

Patch Set 1 #

Patch Set 2 : review #

Total comments: 2

Patch Set 3 : rebase, address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -264 lines) Patch
M ash/accelerators/accelerator_controller.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ash/accelerators/accelerator_controller_unittest.cc View 9 chunks +43 lines, -122 lines 0 comments Download
M ash/accelerators/accelerator_dispatcher.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/accelerators/accelerator_filter.cc View 1 chunk +1 line, -3 lines 0 comments Download
M ash/accelerators/accelerator_table.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/accelerators/accelerator_table.cc View 1 2 2 chunks +67 lines, -120 lines 0 comments Download
M ash/accelerators/nested_dispatcher_controller_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M ash/shell.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M ui/base/accelerators/accelerator_manager.cc View 1 chunk +3 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Yusuke Sato
8 years, 8 months ago (2012-04-23 11:26:58 UTC) #1
mazda
LGTM with a nit http://codereview.chromium.org/10155015/diff/4001/ash/accelerators/accelerator_table.cc File ash/accelerators/accelerator_table.cc (right): http://codereview.chromium.org/10155015/diff/4001/ash/accelerators/accelerator_table.cc#newcode96 ash/accelerators/accelerator_table.cc:96: // EventType, KeyboardCode, shift, control, ...
8 years, 8 months ago (2012-04-23 16:46:16 UTC) #2
Ben Goodger (Google)
LGTM2
8 years, 8 months ago (2012-04-23 16:48:22 UTC) #3
Yusuke Sato
http://codereview.chromium.org/10155015/diff/4001/ash/accelerators/accelerator_table.cc File ash/accelerators/accelerator_table.cc (right): http://codereview.chromium.org/10155015/diff/4001/ash/accelerators/accelerator_table.cc#newcode96 ash/accelerators/accelerator_table.cc:96: // EventType, KeyboardCode, shift, control, alt, AcceleratorAction On 2012/04/23 ...
8 years, 8 months ago (2012-04-24 06:07:31 UTC) #4
commit-bot: I haz the power
8 years, 8 months ago (2012-04-24 06:14:33 UTC) #5

Powered by Google App Engine
This is Rietveld 408576698