Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4647)

Unified Diff: chrome/browser/resources/options2/options_page.js

Issue 10154004: re-use WebUIs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: WeakPtr solution Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/webui/downloads_dom_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/options2/options_page.js
diff --git a/chrome/browser/resources/options2/options_page.js b/chrome/browser/resources/options2/options_page.js
index bc3992da0cb07b3a833de96330dc972074eda619..b8b6d0f33a4da803a92d2a548157947fae195d4c 100644
--- a/chrome/browser/resources/options2/options_page.js
+++ b/chrome/browser/resources/options2/options_page.js
@@ -44,12 +44,6 @@ cr.define('options', function() {
OptionsPage.registeredOverlayPages = {};
/**
- * Whether or not |initialize| has been called.
- * @private
- */
- OptionsPage.initialized_ = false;
-
- /**
* Gets the default page (to be shown on initial load).
*/
OptionsPage.getDefaultPage = function() {
@@ -542,7 +536,6 @@ cr.define('options', function() {
*/
OptionsPage.initialize = function() {
chrome.send('coreOptionsInitialize');
- this.initialized_ = true;
uber.onContentFrameLoaded();
document.addEventListener('scroll', this.handleScroll_.bind(this));
@@ -615,18 +608,6 @@ cr.define('options', function() {
}
};
- /**
- * Re-initializes the C++ handlers if necessary. This is called if the
- * handlers are torn down and recreated but the DOM may not have been (in
- * which case |initialize| won't be called again). If |initialize| hasn't been
- * called, this does nothing (since it will be later, once the DOM has
- * finished loading).
- */
- OptionsPage.reinitializeCore = function() {
- if (this.initialized_)
- chrome.send('coreOptionsInitialize');
- };
-
OptionsPage.prototype = {
__proto__: cr.EventTarget.prototype,
« no previous file with comments | « no previous file | chrome/browser/ui/webui/downloads_dom_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698