Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: chrome/browser/sync/internal_api/write_node.h

Issue 10152003: sync: Make BaseNode lookup-related Init functions return specific failures. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/internal_api/write_node.h
diff --git a/chrome/browser/sync/internal_api/write_node.h b/chrome/browser/sync/internal_api/write_node.h
index ddca68c4adb19714eba416c16e71136614245e8c..7c55ddd0c9207924f17465cd4cee905262c3ad06 100644
--- a/chrome/browser/sync/internal_api/write_node.h
+++ b/chrome/browser/sync/internal_api/write_node.h
@@ -54,9 +54,10 @@ class WriteNode : public BaseNode {
// populate the node.
// BaseNode implementation.
- virtual bool InitByIdLookup(int64 id) OVERRIDE;
- virtual bool InitByClientTagLookup(syncable::ModelType model_type,
- const std::string& tag) OVERRIDE;
+ virtual InitByLookupResult InitByIdLookup(int64 id) OVERRIDE;
+ virtual InitByLookupResult InitByClientTagLookup(
+ syncable::ModelType model_type,
+ const std::string& tag) OVERRIDE;
// Create a new node with the specified parent and predecessor. |model_type|
// dictates the type of the item, and controls which EntitySpecifics proto
@@ -81,7 +82,7 @@ class WriteNode : public BaseNode {
// Each server-created permanent node is tagged with a unique string.
// Look up the node with the particular tag. If it does not exist,
// return false.
- bool InitByTagLookup(const std::string& tag);
+ InitByLookupResult InitByTagLookup(const std::string& tag);
// These Set() functions correspond to the Get() functions of BaseNode.
void SetIsFolder(bool folder);
« no previous file with comments | « chrome/browser/sync/internal_api/syncapi_unittest.cc ('k') | chrome/browser/sync/internal_api/write_node.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698