sync: Make BaseNode lookup-related Init functions return specific failures.

chrome/browser/sync/profile_sync_service_password_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <vector>
 
 #include "testing/gtest/include/gtest/gtest.h"
 
 #include "base/bind.h"
 #include "base/location.h"
@@ skipping 123 matching lines @@
 
 class ProfileSyncServicePasswordTest : public AbstractProfileSyncServiceTest {
  public:
   sync_api::UserShare* GetUserShare() {
     return service_->GetUserShare();
   }
 
   void AddPasswordSyncNode(const PasswordForm& entry) {
     sync_api::WriteTransaction trans(FROM_HERE, service_->GetUserShare());
     sync_api::ReadNode password_root(&trans);
-    ASSERT_TRUE(password_root.InitByTagLookup(browser_sync::kPasswordTag));
+    ASSERT_EQ(sync_api::BaseNode::INIT_OK,
+              password_root.InitByTagLookup(browser_sync::kPasswordTag));
 
     sync_api::WriteNode node(&trans);
     std::string tag = PasswordModelAssociator::MakeTag(entry);
     ASSERT_TRUE(node.InitUniqueByCreation(syncable::PASSWORDS,
                                           password_root,
                                           tag));
     PasswordModelAssociator::WriteToSyncNode(entry, &node);
   }
 
  protected:
@@ skipping 83 matching lines @@
       FlushLastDBTask();
 
       service_->SetEncryptionPassphrase("foo", ProfileSyncService::IMPLICIT);
       MessageLoop::current()->Run();
     }
   }
 
   void GetPasswordEntriesFromSyncDB(std::vector<PasswordForm>* entries) {
     sync_api::ReadTransaction trans(FROM_HERE, service_->GetUserShare());
     sync_api::ReadNode password_root(&trans);
-    ASSERT_TRUE(password_root.InitByTagLookup(browser_sync::kPasswordTag));
+    ASSERT_EQ(sync_api::BaseNode::INIT_OK,
+              password_root.InitByTagLookup(browser_sync::kPasswordTag));
 
     int64 child_id = password_root.GetFirstChildId();
     while (child_id != sync_api::kInvalidId) {
       sync_api::ReadNode child_node(&trans);
-      ASSERT_TRUE(child_node.InitByIdLookup(child_id));
+      ASSERT_EQ(sync_api::BaseNode::INIT_OK,
+                child_node.InitByIdLookup(child_id));
 
       const sync_pb::PasswordSpecificsData& password =
           child_node.GetPasswordSpecifics();
 
       PasswordForm form;
       PasswordModelAssociator::CopyPassword(password, &form);
 
       entries->push_back(form);
 
       child_id = child_node.GetSuccessorId();
@@ skipping 322 matching lines @@
   CreateRootHelper create_root(this, syncable::PASSWORDS);
   StartSyncService(create_root.callback(),
                    base::Bind(&AddPasswordEntriesCallback, this, sync_forms));
 
   std::vector<PasswordForm> new_sync_forms;
   GetPasswordEntriesFromSyncDB(&new_sync_forms);
 
   EXPECT_EQ(1U, new_sync_forms.size());
   EXPECT_TRUE(ComparePasswords(expected_forms[0], new_sync_forms[0]));
 }