sync: Make BaseNode lookup-related Init functions return specific failures.

chrome/browser/sync/internal_api/change_reorder_buffer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/internal_api/change_reorder_buffer.h"
 
 #include <limits>
 #include <queue>
 #include <set>
 #include <utility>  // for pair<>
@@ skipping 133 matching lines @@
       if (specifics_.find(record.id) != specifics_.end())
         record.specifics = specifics_[record.id];
       if (extra_data_.find(record.id) != extra_data_.end())
         record.extra = extra_data_[record.id];
       changelist.push_back(record);
     } else {
       traversal.ExpandToInclude(trans, i->first);
       if (i->second == OP_ADD ||
           i->second == OP_UPDATE_POSITION_AND_PROPERTIES) {
         ReadNode node(sync_trans);
-        CHECK(node.InitByIdLookup(i->first));
+        CHECK_EQ(BaseNode::INIT_OK, node.InitByIdLookup(i->first));
 
         // We only care about parents of entry's with position-sensitive models.
         if (syncable::ShouldMaintainPosition(
                 node.GetEntry()->GetModelType())) {
           parents_of_position_changes.insert(node.GetParentId());
         }
       }
     }
   }
 
@@ skipping 55 matching lines @@
         id = child.Get(syncable::NEXT_ID);
       }
     }
   }
 
   *changes = ImmutableChangeRecordList(&changelist);
   return true;
 }
 
 }  // namespace sync_api